-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omero render set: clarify help around settings for disabled channels #67
Conversation
Co-authored-by: pwalczysko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sbesson - please see 2 reformulation suggestions. To be fair, I did understand your formulation too.
Co-authored-by: pwalczysko <[email protected]>
Thanks @pwalczysko slightly reformulated the second sentence to make it more grammatically correct. Can you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I cannot find a fault, both understanding and grammar seems +1 to me. Thanks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release as 0.8.2?
I think there is harm in releasing the package with the updated help message. Possibly depends on whether there are other candidates for inclusion. |
Nothing really in the pipeline as far as I can tell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes #66
The underlying code change has been applied in #43 and released since
omero-cli-render 0.6.0
but the help was never updated and was still documenting the previous behavior.