Fix/aut 3923/textreader image figure support #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version
There are 0 BREAKING CHANGE, 0 feature, 2 fixes |
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/AUT-3923
Changes
mediaAlignment/helperIn TextReader PCI,
parent.contentModel && parent.contentModel === 'inlineStatic'didn't pass becauseparent.contentModelwas undefined. Becausewidget.refreshdidn't run, something wasn't updated, and image align reverted to Inline.It seemed fine to always call
widget.refreshinstead ofactive/sleep/activefor other cases (A-block, ChoiceInteraction choice), not only for Prompt. Only for prompts of MathEntry/Likert PCI, there was now "QTI XML compilation error" when there was<figure>in the prompt (figure wasn't allowed before, for same reason as in TextReader PCI), but it was solved by another change in Fix/aut 3923/textreader image figure support extension-tao-itemqti#2613This code was added in fix/AUT-2673/inline-figure-img #528, and
refreshwas added at the last moment.FigureStateActiveImage Caption textarea in Authoring side panel: it was completely collapsed for newly added images. Add some min-height to it. Image Caption textarea appears after you wrap inline image.
Test
On unit05. Related PRs: