Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/aut 3923/textreader image figure support #172

Open
wants to merge 5 commits into
base: fix/AUT-3876/editor-passage-remove
Choose a base branch
from

Conversation

olga-kulish
Copy link

@olga-kulish olga-kulish commented Nov 8, 2024

Related to https://oat-sa.atlassian.net/browse/AUT-3923

Changes

  1. textReaderInteraction.scss
    Position "remove" icon for Figure. Same style is used in taoQtiItem-->item-creator.css for inline widgets.

  2. Question.js
    Set data-element-support-figure - this is needed for Fix/aut 3923/textreader image figure support extension-tao-itemqti#2613 where we check if <figure> is supported (if it's not supported, wrap-left/wrap-right will be applied directly to <img>).
    In pratice the difference is whether figcaption is available or not. So we could remove this data attribute for simplicity, and just disable <figure> for all PCIs.

  3. renderer.js
    Since usual renderers of QTI elements don't run in PCI, we need to copy this functionality inside PCI. Maybe this should be moved to portableLib. Need to remove qh5: namespace too.

Notes

When I click on Figure in CkEditor, there's an error:

Uncaught TypeError: Cannot read properties of undefined (reading 'p')
    at CKEDITOR.dom.elementPath.isContextFor (ckeditor.js?buster=67281c6ecaeb3:509:149)
    at CKEDITOR.command.refresh (ckeditor.js?buster=67281c6ecaeb3:209:273)
    at m (ckeditor.js?buster=67281c6ecaeb3:265:233) ...

I have no idea how to fix it yet. Looks harmless, so let's ignore it?
To get rid of it, we can sacrifice figcaption and disable <figure> support (and apply wrap class directly on <img>).

To test

On unit05. Related PRs:

@olga-kulish olga-kulish changed the base branch from master to develop November 8, 2024 06:43
@olga-kulish olga-kulish changed the base branch from develop to fix/AUT-3876/editor-passage-remove November 8, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant