Fix/aut 3923/textreader image figure support #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://oat-sa.atlassian.net/browse/AUT-3923
Changes
textReaderInteraction.scss
Position "remove" icon for Figure. Same style is used in
taoQtiItem-->item-creator.css
for inline widgets.Question.js
Set
data-element-support-figure
- this is needed for Fix/aut 3923/textreader image figure support extension-tao-itemqti#2613 where we check if<figure>
is supported (if it's not supported,wrap-left/wrap-right
will be applied directly to<img>
).In pratice the difference is whether
figcaption
is available or not. So we could remove this data attribute for simplicity, and just disable<figure>
for all PCIs.renderer.js
Since usual renderers of QTI elements don't run in PCI, we need to copy this functionality inside PCI. Maybe this should be moved to portableLib. Need to remove
qh5:
namespace too.Notes
When I click on Figure in CkEditor, there's an error:
I have no idea how to fix it yet. Looks harmless, so let's ignore it?
To get rid of it, we can sacrifice
figcaption
and disable<figure>
support (and apply wrap class directly on<img>
).To test
On unit05. Related PRs: