Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional GPP-382 and GPP-383 Changes #117

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Additional GPP-382 and GPP-383 Changes #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3e7d3a
Switched position of heading and button for filters panel. Changed la…
johnyu95 Jun 15, 2020
65f92d8
Updates to focus color on nav section
johnyu95 Jun 15, 2020
f12fd93
Changed color for search button and switch language
johnyu95 Jun 16, 2020
16231b8
Update visual indicator for NYC logo and footer link
johnyu95 Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions app/assets/stylesheets/gpp.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,11 @@ body.gpp-dashboard {
text-decoration: underline;
}

.navbar-link:focus {
outline: 2px solid white !important;
outline-offset: 1px !important;
}

a.gpp-nav-link:hover, a.gpp-nav-link:focus {
text-decoration: underline !important;
}
Expand All @@ -299,4 +304,24 @@ table#activity a {
// Changes color of focus outline globally
:focus{
outline: 2px solid #337ab7 !important;
}

li.nav-item a:focus{
outline: 2px solid white !important;
}

a.navbar-brand:focus {
outline: 2px solid white !important;
}

.switch-language {
color: black !important;
}

.upper-header-left {
padding-left: 10px;
a:focus {
outline: 2px solid white !important;
outline-offset: 1px !important;
}
}
22 changes: 22 additions & 0 deletions app/views/catalog/_facets.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<% # main container for facets/limits menu -%>
<% if has_facet_values? %>
<div id="facets" class="facets sidenav">

<div class="top-panel-heading panel-heading">
<h2 class="facets-heading" style="display: inline-block;">
<%= t('blacklight.search.facets.title') %>
</h2>

<button type="button" class="facets-toggle" data-toggle="collapse" data-target="#facet-panel-collapse">
<span class="sr-only">Filters</span>
<span class="icon-bar"></span>
<span class="icon-bar"></span>
<span class="icon-bar"></span>
</button>
</div>

<div id="facet-panel-collapse" class="collapse panel-group">
<%= render_facet_partials %>
</div>
</div>
<% end %>
11 changes: 5 additions & 6 deletions app/views/catalog/_search_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@
aria_label: "Search Field" %>

<div class="input-group-btn">
<button type="submit" class="btn btn-primary" id="search-submit-header" aria-label="Search">
<button type="submit" class="btn btn-default" id="search-submit-header" aria-label="Search">
<%= t('hyrax.search.button.html') %>
</button>
<button class="btn btn-default" type="button" aria-label="Advanced Search Options">
<%= link_to 'More options',
blacklight_advanced_search_engine.advanced_search_path(search_state.to_h),
class: 'advanced_search underline-link' %>
</button>
<%= link_to 'More Options',
blacklight_advanced_search_engine.advanced_search_path(search_state.to_h),
class: 'advanced_search underline-link btn btn-default',
aria: { label: 'Advanced Search Options' } %>
</div><!-- /.input-group-btn -->
</div><!-- /.input-group -->

Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/hyrax.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</div>
<% end %>

<a name="skip-to-content" id="skip-to-content" tabindex="0"></a>
<a id="skip-to-content"></a>
<%= content_for?(:content) ? yield(:content) : yield %>

</div><!-- /#content-wrapper -->
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_locale_picker.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<b class="caret"></b>
</a>
<ul id="language-dropdown-menu" class="dropdown-menu" role="menu">
<li role="presentation" class="dropdown-header"><%= t('hyrax.toolbar.language_switch') %></li>
<li role="presentation" class="dropdown-header switch-language"><%= t('hyrax.toolbar.language_switch') %></li>
<li role="presentation" class="divider"></li>
<% available_translations.each do |language, label| %>
<li role="presentation" lang="<%= language %>">
Expand Down