Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional GPP-382 and GPP-383 Changes #117

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

johnyu95
Copy link
Contributor

Additional 508 changes based on Walei and Arthur's latest feedback

Changes made:

  • Switched position of "Limit your search" heading and button to expand filters (this is intended for mobile view of page).
  • Changed label of button to expand filters from "Toggle Facets" to "Filters".
  • Changed focus outline for homepage link, language picker, and login button to white for better visibility.
  • Changed color of "Go" button for better visibility with the focus outline.
  • Changed "More Options" button into just a link styled as a button instead of a link inside of a button. This is to remove extra tabbing after focus is already on the button.
  • Removed tabindex attribute from skip to link to remove extra tabbing and removed name attribute because it is deprecated.

@johnyu95 johnyu95 requested a review from zgary June 16, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants