Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat print line to get rid off unwanted spaces #606

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

WardDeb
Copy link

@WardDeb WardDeb commented Dec 11, 2023

Hi, Thanks for the software !
I've noticed that the extract_snps script introduces spaces directly after the geno[1] field, at the position where the print line is split up over multiple lines. This causes issues in the assignment later on as no reads can be assigned to the alternative genotype. The pipeline fails later in the matrix generation.

Reformatting this line gets rid of the spaces and fixes the issues downstream.

I've tested with mgp_REL2021_snps.vcf.gz, corresponding to GRCm39.

Related to #572.

Kind regards,

WardDeb

@nservant nservant changed the base branch from master to devel January 26, 2024 17:05
@nservant nservant self-requested a review January 26, 2024 17:11
@nservant
Copy link
Owner

nservant commented Jan 26, 2024

Hi @WardDeb
Sorry for the delay ... I approved your PR but there is a conflict I do not understand.
I'll keep that in mind, and make the modification by hand if necessary.
Sorry for that
N

@WardDeb
Copy link
Author

WardDeb commented Jan 26, 2024

Thanks @nservant ! and no worries for the delay.
I think the conflict came from this line being updated in the devel branch (I forked from master initially).
I've resolved the conflict but feel free to move on as you see fit :)

Cheers,

WardDeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants