Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: program failing when unknown record type is in zone #56

Merged
merged 1 commit into from
Jun 4, 2024

Commits on Feb 26, 2024

  1. fix: program failing when unknown record type is in zone

    The upstream `cloudflare` crate does not support parsing CAA records
    (and others), which means that the result of the record listing endpoint
    cannot be parsed by cfdyndns, resulting in a crash.
    
    This PR adds a filter to the requests to only get A and AAAA records.
    However, due to the design of the upstream crate, it is not possible to
    filter by type without also filtering by content, meaning we have to
    change the `match` parameter to `any`. Additionally, the API only allows
    to filter by a single type, which means we duplicate the number of
    requests by making one request for A records and another for AAAA
    records.
    
    Fixes nrdxp#54
    diogotcorreia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1c7a3a4 View commit details
    Browse the repository at this point in the history