fix: program failing when unknown record type is in zone #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream `cloudflare` crate does not support parsing CAA records (and others), which means that the result of the record listing endpoint cannot be parsed by cfdyndns, resulting in a crash. This PR adds a filter to the requests to only get A and AAAA records. However, due to the design of the upstream crate, it is not possible to filter by type without also filtering by content, meaning we have to change the `match` parameter to `any`. Additionally, the API only allows to filter by a single type, which means we duplicate the number of requests by making one request for A records and another for AAAA records. Fixes nrdxp#54
diogotcorreia
added a commit
to diogotcorreia/dotfiles
that referenced
this pull request
Feb 26, 2024
fadenb
approved these changes
May 29, 2024
nrdxp
approved these changes
Jun 4, 2024
|
I dunno why CI didn't trigger for this PR. I also don't see the usual section to "approve" the workflow to run for this PR. Given that everything is configured properly and I am the repo owner, I must assume that something strange happened on GitHub's side unless I overlooked something. In any case I will run it manually and merge if it passes. Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream
cloudflarecrate does not support parsing CAA records (and others), which means that the result of the record listing endpoint cannot be parsed by cfdyndns, resulting in a crash.This PR adds a filter to the requests to only get A and AAAA records. However, due to the design of the upstream crate, it is not possible to filter by type without also filtering by content, meaning we have to change the
matchparameter toany. Additionally, the API only allows to filter by a single type, which means we duplicate the number of requests by making one request for A records and another for AAAA records.Fixes #54