Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix localization data for ICU 74.2 #56661

Merged
merged 1 commit into from
Jan 23, 2025
Merged

test: fix localization data for ICU 74.2 #56661

merged 1 commit into from
Jan 23, 2025
+6 −6

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 19, 2025

Refs: #55618

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 19, 2025
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 19, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (da5f7ac) to head (91c2f37).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56661      +/-   ##
==========================================
- Coverage   89.21%   89.20%   -0.01%     
==========================================
  Files         662      662              
  Lines      191893   191893              
  Branches    36936    36931       -5     
==========================================
- Hits       171189   171184       -5     
- Misses      13541    13554      +13     
+ Partials     7163     7155       -8

see 43 files with indirect coverage changes

lpinca
lpinca approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 22, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64605/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64625/

BridgeAR
BridgeAR approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tests not normally run in the CI? Or do we know why it wasn't detected earlier?

mhdawson
mhdawson approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64637/

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 23, 2025

Are these tests not normally run in the CI? Or do we know why it wasn't detected earlier?

I don't think it's run on the CI, IIUC the CI only builds with ICU 75.1 or later

@richardlau
Copy link
Member

Are these tests not normally run in the CI? Or do we know why it wasn't detected earlier?

I don't think it's run on the CI, IIUC the CI only builds with ICU 75.1 or later

Most of the CI jobs (Jenkins and GHA) will run with whatever ICU is in deps/icu-small. The one exception is the ubuntu2204_sharedlibs_icu_x64 variant of node-test-commit-linux-containered which builds Node.js linked with the lowest version of ICU that is compatible with Node.js (defined in tools/icu/icu_versions.json, e.g. right now for main:

node/tools/icu/icu_versions.json

Line 2 in d978610

"minimum_icu": 73
(see also

node/deps/v8/src/objects/intl-objects.h

Line 25 in d978610

#define V8_MINIMUM_ICU_VERSION 73
)). This job variant is there to check we don't break anyone on earlier (but still compatible) ICU versions -- we don't currently test on every available version of ICU (for e.g. Node.js 18 that would be seven versions of ICU (69 to 76)).

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64648/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64664/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit 869d0cb into nodejs:main Jan 23, 2025
74 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 869d0cb

@aduh95 aduh95 deleted the icu-74.2-test-data branch January 23, 2025 22:18
aduh95 added a commit that referenced this pull request Jan 27, 2025
@aduh95
test: fix localization data for ICU 74.2
88f4fc3 
PR-URL: #56661
Refs: #55618
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Open
aduh95 added a commit that referenced this pull request Jan 30, 2025
@aduh95
test: fix localization data for ICU 74.2
f885496 
PR-URL: #56661
Refs: #55618
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @richardlau @jasnell @lpinca @BridgeAR @mhdawson @LiviaMedeiros