Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025-01-29, Version 23.7.0 (Current) #56800

Open
wants to merge 159 commits into
base: v23.x
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 28, 2025

Notable Changes

  • [2f39b73e5a] - crypto: update root certificates to NSS 3.107 (Node.js GitHub Bot) #56566
  • [df60f51617] - (SEMVER-MINOR) fs: allow exclude option in globs to accept glob patterns (Daeyeon Jeong) #56489
  • [e6692973a2] - (SEMVER-MINOR) module: add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX (Marco Ippolito) #56610
  • [1e201fd5fd] - (SEMVER-MINOR) sqlite: support TypedArray and DataView in StatementSync (Alex Yang) #56385
  • [57d15a72ff] - (SEMVER-MINOR) src: add --disable-sigusr1 to prevent signal i/o thread (Rafael Gonzaga) #56441
  • [f4ff93d4e4] - (SEMVER-MINOR) src,worker: add isInternalWorker (Carlos Espa) #56469
  • [bbc5623d8a] - (SEMVER-MINOR) test_runner: add TestContext.prototype.waitFor() (Colin Ihrig) #56595
  • [e6b4314b50] - (SEMVER-MINOR) test_runner: add t.assert.fileSnapshot() (Colin Ihrig) #56459
  • [3143566045] - (SEMVER-MINOR) test_runner: add assert.register() API (Colin Ihrig) #56434
Commits
  • [3d818e3338] - assert: make myers_diff function more performant (Giovanni Bucci) #56303
  • [4faa0d80e5] - assert: make partialDeepStrictEqual work with urls and File prototypes (Giovanni Bucci) #56231
  • [b0791bc856] - assert: show diff when doing partial comparisons (Giovanni Bucci) #56211
  • [9c27e7ccad] - benchmark: add validateStream to styleText bench (Rafael Gonzaga) #56556
  • [0178f8915e] - child_process: fix parsing messages with splitted length field (Maksim Gorkov) #56106
  • [908496c190] - crypto: add missing return value check (Michael Dawson) #56615
  • [2f39b73e5a] - crypto: update root certificates to NSS 3.107 (Node.js GitHub Bot) #56566
  • [7ce2452479] - crypto: fix checkPrime crash with large buffers (Santiago Gimeno) #56559
  • [6106dade1e] - crypto: fix warning of ignoring return value (Cheng) #56527
  • [d30002771c] - crypto: make generatePrime/checkPrime interruptible (James M Snell) #56460
  • [68a112e1e5] - deps: update corepack to 0.31.0 (Node.js GitHub Bot) #56795
  • [1ce1940ba1] - deps: move inspector_protocol to deps (Chengzhong Wu) #56649
  • [de3360048c] - deps: macro ENODATA is deprecated in libc++ (Cheng) #56698
  • [359039c7d3] - deps: fixup some minor coverity warnings (James M Snell) #56612
  • [38748d884f] - deps: update libuv to 1.50.0 (Node.js GitHub Bot) #56616
  • [9f859684b6] - deps: update amaro to 0.3.0 (Node.js GitHub Bot) #56568
  • [9b0e40fdab] - deps: update amaro to 0.2.2 (Node.js GitHub Bot) #56568
  • [b6e9f87e1b] - deps: update simdutf to 6.0.3 (Node.js GitHub Bot) #56567
  • [54a0b0f01e] - diagnostics_channel: capture console messages (Stephen Belanger) #56292
  • [ffee446290] - doc: move anatoli to emeritus (Michael Dawson) #56592
  • [c7c4323c70] - doc: fix styles of the expandable TOC (Antoine du Hamel) #56755
  • [b666ba3cff] - doc: add "Skip to content" button (Antoine du Hamel) #56750
  • [7de46dace3] - doc: improve accessibility of expandable lists (Antoine du Hamel) #56749
  • [93652f9f3a] - doc: add note regarding commit message trailers (Dario Piotrowicz) #56736
  • [1d939ddd7d] - doc: fix typo in example code for util.styleText (Robin Mehner) #56720
  • [f3bda6133a] - doc: fix inconsistencies in WeakSet and WeakMap comparison details (Shreyans Pathak) #56683
  • [185fe7d14b] - doc: add RafaelGSS as latest sec release stewards (Rafael Gonzaga) #56682
  • [434ef856d7] - doc: clarify cjs/esm diff in queueMicrotask() vs process.nextTick() (Dario Piotrowicz) #56659
  • [f3b44a6881] - doc: WeakSet and WeakMap comparison details (Shreyans Pathak) #56648
  • [5d95506714] - doc: mention prepare --security (Rafael Gonzaga) #56617
  • [e834633f0a] - doc: tweak info on reposts in ambassador program (Michael Dawson) #56589
  • [7bac1d2125] - doc: add type stripping to ambassadors program (Marco Ippolito) #56598
  • [d960a15dd4] - doc: improve internal documentation on built-in snapshot (Joyee Cheung) #56505
  • [7f4bc3e22f] - doc: correct customization hook types & clarify descriptions (Jacob Smith) #56454
  • [5acee51e57] - doc: document CLI way to open the nodejs/bluesky PR (Antoine du Hamel) #56506
  • [1ffbd6e728] - doc: add history info for Permission Model (Antoine du Hamel) #56707
  • [1adf2b46e9] - doc: add note for features using InternalWorker with permission model (Antoine du Hamel) #56706
  • [a0425b8eb3] - doc: add section about using npx with permission model (Rafael Gonzaga) #56539
  • [f20ec5c0c5] - doc: update gcc-version for ubuntu-lts (Kunal Kumar) #56553
  • [97ca0d7390] - doc: fix parentheses in options (Tobias Nießen) #56563
  • [0f7ab198d7] - doc: fix location of NO_COLOR in CLI docs (Colin Ihrig) #56525
  • [974c5f8972] - doc: include CVE to EOL lines as sec release process (Rafael Gonzaga) #56520
  • [bf866fe066] - doc: add esm examples to node:trace_events (Alfredo González) #56514
  • [c5152e5148] - doc: reserve NMV 133 for Electron 35 (Keeley Hammond) #56513
  • [c3114bf528] - doc: add message for Ambassadors to promote (Michael Dawson) #56235
  • [0afd4bc4c8] - doc: allow request for TSC reviews via the GitHub UI (Antoine du Hamel) #56493
  • [080d0bfa72] - esm: fix jsdoc type refs to ModuleJobBase in esm/loader (Jacob Smith) #56499
  • [df60f51617] - (SEMVER-MINOR) fs: allow exclude option in globs to accept glob patterns (Daeyeon Jeong) #56489
  • [3f47beb74e] - http2: omit server name when HTTP2 host is IP address (islandryu) #56530
  • [af23638454] - inspector: roll inspector_protocol (Chengzhong Wu) #56649
  • [2785a93fe7] - inspector: add undici http tracking support (Chengzhong Wu) #56488
  • [f185e8a34a] - inspector: report loadingFinished until the response data is consumed (Chengzhong Wu) #56372
  • [e468cd62ed] - lib: allow skipping source maps in node_modules (Chengzhong Wu) #56639
  • [867ae75537] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #56580
  • [ad1ade55b9] - meta: add codeowners of security release document (Rafael Gonzaga) #56521
  • [327a89e670] - module: fix bad require.resolve with option paths for . and .. (Dario Piotrowicz) #56735
  • [ac8124b00f] - module: integrate TypeScript into compile cache (Joyee Cheung) #56629
  • [e195dba563] - module: use more defensive code when handling SWC errors (Antoine du Hamel) #56646
  • [f4ce91b251] - module: fixing url change in load sync hook chain (Vitalii Akimov) #56402
  • [e6692973a2] - (SEMVER-MINOR) module: add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX (Marco Ippolito) #56610
  • [3e7bb3e68e] - module: fix jsdoc for format parameter in cjs/loader (pacexy) #56501
  • [593aa11b3a] - module: rethrow amaro error message (Marco Ippolito) #56568
  • [e6a821e22c] - process: fix symbol key and mark experimental new node:process methods (Antoine du Hamel) #56517
  • [92f3759ec2] - punycode: limit deprecation warning (Colin Ihrig) #56632
  • [9b13207f3f] - quic: fixup errant LocalVector usage (James M Snell) #56564
  • [df939c2ffe] - sqlite: disable memstatus APIs at build time (Colin Ihrig) #56541
  • [1e201fd5fd] - (SEMVER-MINOR) sqlite: support TypedArray and DataView in StatementSync (Alex Yang) #56385
  • [3aca628a11] - sqlite: enable SQL math functions (Colin Ihrig) #56447
  • [303e44c659] - src: add nullptr handling from X509_STORE_new() (Burkov Egor) #56700
  • [3107f5a617] - src: move more crypto to ncrypto (James M Snell) #56653
  • [2259117c99] - src: add default value for RSACipherConfig mode field (Burkov Egor) #56701
  • [d84b3a935a] - src: fix build with GCC 15 (tjuhaszrh) #56740
  • [06707770c1] - src: fix to generate path from wchar_t via wstring (yamachu) #56696
  • [0d28b6c714] - src: replace NoArrayBufferZeroFillScope with v8 option (James M Snell) #56658
  • [d276bd1f7d] - src: initialize FSReqWrapSync in path that uses it (Michaël Zasso) #56613
  • [85bc4ebebe] - src: use cppgc to manage ContextifyContext (Joyee Cheung) #56522
  • [448885d038] - src: handle duplicate paths granted (Rafael Gonzaga) #56591
  • [df9eed4b71] - src: update ECKeyPointer in ncrypto (James M Snell) #56526
  • [70bf53564e] - src: update ECPointPointer in ncrypto (James M Snell) #56526
  • [73f7df9c98] - src: update ECGroupPointer in ncrypto (James M Snell) #56526
  • [6234271fa4] - src: update ECDASSigPointer implementation in ncrypto (James M Snell) #56526
  • [77b58a479e] - src: cleaning up more crypto internals for ncrypto (James M Snell) #56526
  • [57d15a72ff] - (SEMVER-MINOR) src: add --disable-sigusr1 to prevent signal i/o thread (Rafael Gonzaga) #56441
  • [97f6dfeb13] - src: fix undefined script name in error source (Chengzhong Wu) #56502
  • [ffe6d9e030] - src: refactor --trace-env to reuse option selection and handling (Joyee Cheung) #56293
  • [b4f7a68fcd] - src: minor cleanups on OneByteString usage (James M Snell) #56482
  • [0d7de43c77] - src: move more crypto impl detail to ncrypto dep (James M Snell) #56421
  • [a91295f0c5] - src: fixup more ToLocalChecked uses in node_file (James M Snell) #56484
  • [1c825f3f14] - src: make some minor ToLocalChecked cleanups (James M Snell) #56483
  • [11fee32fc0] - src: lock the thread properly in snapshot builder (Joyee Cheung) #56327
  • [3fa90e8d31] - src: drain platform tasks before creating startup snapshot (Chengzhong Wu) #56403
  • [e1887d2c58] - src: use LocalVector in more places (James M Snell) #56457
  • [3159b7c726] - src, quic: refine more of the quic implementation (James M Snell) #56328
  • [f4ff93d4e4] - (SEMVER-MINOR) src,worker: add isInternalWorker (Carlos Espa) #56469
  • [b140d1c08e] - stream: fix typo in ReadableStreamBYOBReader.readIntoRequests (Mattias Buelens) #56560
  • [ac9564879a] - test: reduce number of written chunks (Luigi Pinca) #56757
  • [4f475e1292] - test: fix invalid common.mustSucceed() usage (Luigi Pinca) #56756
  • [c9f2e30e9b] - test: use strict mode in global setters test (Rich Trott) #56742
  • [d3136d1f62] - test: cleanup and simplify test-crypto-aes-wrap (James M Snell) #56748
  • [688ce62c07] - test: do not use common.isMainThread (Luigi Pinca) #56768
  • [eaa3e59125] - test: make some requires lazy in common/index (James M Snell) #56715
  • [e25ec1fa4d] - test: add test that uses multibyte for path and resolves modules (yamachu) #56696
  • [702402397d] - test: replace more uses of global with globalThis (James M Snell) #56712
  • [4776119e19] - test: make common/index slightly less node.js specific (James M Snell) #56712
  • [27c5e8d40d] - test: rely less on duplicative common test harness utilities (James M Snell) #56712
  • [c529fab7f9] - test: simplify common/index.js (James M Snell) #56712
  • [663f413f36] - test: move hasMultiLocalhost to common/net (James M Snell) #56716
  • [b1fd20c00d] - test: move crypto related common utilities in common/crypto (James M Snell) #56714
  • [f3efb21881] - test: add missing test for env file (Jonas) #56642
  • [59226cc809] - test: enforce strict mode in test-zlib-const (Rich Trott) #56689
  • [88f4fc34f6] - test: fix localization data for ICU 74.2 (Antoine du Hamel) #56661
  • [becb40cc52] - test: use --permission instead of --experimental-permission (Rafael Gonzaga) #56685
  • [6cc91b4c96] - test: test-stream-compose.js doesn't need internals (Meghan Denny) #56619
  • [e288137484] - test: add maxCount and gcOptions to gcUntil() (Joyee Cheung) #56522
  • [6e99f552e7] - test: add line break at end of file (Rafael Gonzaga) #56588
  • [01e0c8a267] - test: mark test-worker-prof as flaky on smartos (Joyee Cheung) #56583
  • [13a1089cb4] - test: update ts eval snapshots (Marco Ippolito) #56568
  • [25a62dcde1] - test: update test-child-process-bad-stdio to use node:test (Colin Ihrig) #56562
  • [34d84a37b5] - test: disable openssl 3.4.0 incompatible tests (Jelle van der Waa) #56160
  • [d0002e3120] - test: make test-crypto-hash compatible with OpenSSL > 3.4.0 (Jelle van der Waa) #56160
  • [e9d231d0a2] - test: clarify fork inherit permission flags (Rafael Gonzaga) #56523
  • [ce951a7cab] - test: add error only reporter for node:test (Carlos Espa) #56438
  • [6e2e829b8c] - test: mark test-http-server-request-timeouts-mixed as flaky (Joyee Cheung) #56503
  • [295db19ba2] - test: update error code in tls-psk-circuit for for OpenSSL 3.4 (sebastianas) #56420
  • [f7563780a6] - test: update compiled sqlite tests to match other tests (Colin Ihrig) #56446
  • [8feb2737e7] - test: add initial test426 coverage (Chengzhong Wu) #56436
  • [b9cd7895c0] - test: update test-set-http-max-http-headers to use node:test (Colin Ihrig) #56439
  • [332ce548cb] - test: update test-child-process-windows-hide to use node:test (Colin Ihrig) #56437
  • [b5dfbb8691] - test_runner: print failing assertion only once with spec reporter (Pietro Marchini) #56662
  • [8c4fe0383f] - test_runner: remove unused errors (Pietro Marchini) #56607
  • [bbc5623d8a] - (SEMVER-MINOR) test_runner: add TestContext.prototype.waitFor() (Colin Ihrig) #56595
  • [e6b4314b50] - (SEMVER-MINOR) test_runner: add t.assert.fileSnapshot() (Colin Ihrig) #56459
  • [03ef6e965c] - test_runner: run single test file benchmark (Pietro Marchini) #56479
  • [839a06e908] - test_runner: differentiate test types in enqueue dequeue events (Eddie Abbondanzio) #54049
  • [3143566045] - (SEMVER-MINOR) test_runner: add assert.register() API (Colin Ihrig) #56434
  • [3aa864904f] - test_runner: finish marking snapshot testing as stable (Colin Ihrig) #56425
  • [b975aa5bc9] - tls: fix error stack conversion in cryptoErrorListToException() (Joyee Cheung) #56554
  • [47ee6d3ca9] - tools: update doc to new version (Node.js GitHub Bot) #56259
  • [7f6a16a0e1] - tools: update inspector_protocol roller (Chengzhong Wu) #56649
  • [5e4f85cec4] - tools: do not throw on missing create-release-proposal.sh (Antoine du Hamel) #56704
  • [dac163947e] - tools: fix tools-deps-update (Daniel Lemire) #56684
  • [7aed11bde2] - tools: do not throw on missing create-release-proposal.sh (Antoine du Hamel) #56695
  • [a1e4fb6e59] - tools: fix permissions in lint-release-proposal workflow (Antoine du Hamel) #56614
  • [22fa8362d0] - tools: remove github reporter (Carlos Espa) #56468
  • [3f027ce4df] - tools: edit create-release-proposal workflow (Antoine du Hamel) #56540
  • [92ebb2a9c5] - tools: validate commit list as part of lint-release-commit (Antoine du Hamel) #56291
  • [88015a082c] - tools: fix loong64 build failed (Xiao-Tao) #56466
  • [aea088f79e] - tools: disable unneeded rule ignoring in Python linting (Rich Trott) #56429
  • [7a0dd2d04f] - tools: use a configurable value for number of open dependabot PRs (Antoine du Hamel) #56427
  • [c249c9715a] - tools: bump the eslint group in /tools/eslint with 4 updates (dependabot[bot]) #56426
  • [b36eee4629] - util: inspect: do not crash on an Error stack that contains a Symbol (Jordan Harband) #56573
  • [5f79b638c1] - util: inspect: do not crash on an Error with a regex name (Jordan Harband) #56574
  • [dd07b6dbc9] - util: rename CallSite.column to columnNumber (Chengzhong Wu) #56584
  • [ebc4ce9153] - util: do not crash on inspecting function with Symbol name (Jordan Harband) #56572
  • [dbe67a955c] - util: expose CallSite.scriptId (Chengzhong Wu) #56551
  • [88b0985641] - watch: reload env file for --env-file-if-exists (Jonas) #56643
  • [ae4c7fa5d6] - worker: refactor stdio to improve performance (Matteo Collina) #56630
  • [aab53e6965] - worker: flush stdout and stderr on exit (Matteo Collina) #56428

cjihrig and others added 30 commits January 21, 2025 13:37
Snapshot testing was marked stable in #55897. These were
overlooked at the time.

Refs: #55897
PR-URL: #56425
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Bumps the eslint group in /tools/eslint with 4 updates: [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js), [eslint](https://github.com/eslint/eslint), [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) and [globals](https://github.com/sindresorhus/globals).

Updates `@stylistic/eslint-plugin-js` from 2.11.0 to 2.12.1
- [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases)
- [Changelog](https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v2.12.1/packages/eslint-plugin-js)

Updates `eslint` from 9.16.0 to 9.17.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.16.0...v9.17.0)

Updates `eslint-plugin-jsdoc` from 50.6.0 to 50.6.1
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases)
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc)
- [Commits](gajus/eslint-plugin-jsdoc@v50.6.0...v50.6.1)

Updates `globals` from 15.12.0 to 15.14.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](sindresorhus/globals@v15.12.0...v15.14.0)

---
updated-dependencies:
- dependency-name: "@stylistic/eslint-plugin-js"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint-plugin-jsdoc
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: eslint
- dependency-name: globals
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #56426
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
This way, we can disable all dependabot PRs from private forks.

PR-URL: #56427
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Removing PLC1901 and RUF100 from the list of Python lint rules to ignore
does not result in any errors. Keeping the ignore list as short as
possible seems like a good idea, so this change removes them from the
ignore list.

PR-URL: #56429
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
This commit updates test/parallel/test-child-process-windows-hide.js
to use node:test. This allows the test to use the built in mocking
functionality instead of managing spies manually. It also prevents
multiple child processes from being spawned in parallel, which can
be problematic in the CI.

PR-URL: #56437
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This commit adds a top level assert.register() API to the test
runner. This function allows users to define their own custom
assertion functions on the TestContext.

Fixes: #52033
PR-URL: #56434
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
This commit updates test/parallel/test-set-http-max-http-headers.js
to use node:test. This test already implemented a test runner, so
it makes sense to use the existing public API.

PR-URL: #56439
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Source map has been standardized as ECMA426, with a developing test
suite. Add an initial coverage of the source map tests.

PR-URL: #56436
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
This commit updates the sqlite compiled tests to be structured
like other compiled tests.

Refs: #56347
PR-URL: #56446
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stewart X Addison <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
This commit enables SQLite math functions.

Fixes: #56435
PR-URL: #56447
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #54049
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #56385
Fixes: #56384
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
The `Network.loadingFinished` should be deferred until the response is
complete and the data is fully consumed. Also, report correct request
url with the specified port by retrieving the host from the request
headers.

PR-URL: #56372
Refs: #53946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
PR-URL: #56457
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #56428
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Update parallel/test-tls-psk-circuit.js to account for error code
changes in OpenSSL 3.4 and probably later.

Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
PR-URL: #56420
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Signed-off-by: James M Snell <[email protected]>
PR-URL: #56328
Reviewed-By: Yagiz Nizipli <[email protected]>
Drain the loop and platform tasks before creating a snapshot. This is
necessary to ensure that the no roots are held by the the platform
tasks, which may reference objects associated with a context. For
example, a WeakRef may schedule an per-isolate platform task as a GC
root, and referencing an object in a context, causing an assertion in
the snapshot creator.

PR-URL: #56403
Refs: #56292
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #56466
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Otherwise it can crash DCHECK when V8 expects that at least someone
is locking the current thread.

PR-URL: #56327
Fixes: nodejs/node-v8#294
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #56483
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #56484
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
The `generatePrime` and `checkPrime` functions in the `crypto`
module are only somewhat interruptible. This change makes it
possible to interrupt these more reliably. Note that generating
overly large primes can still take a long time and may not be
interruptible as this mechanism relies on a callback to check
for stopping conditions but OpenSSL may perform a long running
operation without calling the callback right away.

Fixes: #56449
PR-URL: #56460
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
* remove obsolete LogSecret function
* move StackOfX509 decl to ncrypto
* colocate GetSSLOCSPResponse with callsite
* move x509 error code and reason to ncrypto
* simplify X509Pointer/X509View pointer derefs a bit
* move prime gen and checks to ncrypto
* move BN_* methods into ncrypto
* move SSLPointer impl to ncrypto
* move SSLCtxPointer impl to ncrypto
* move EVP_CIPHER methods to ncrypto
* move CipherCtx methods to ncrypto

PR-URL: #56421
Reviewed-By: Yagiz Nizipli <[email protected]>
* Provide a OneByteString variant that accepts std::string_view
* Use FIXED_ONE_BYTE_STRING in appropriate places

Signed-off-by: James M Snell <[email protected]>
PR-URL: #56482
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Add basic undici http tracking support via inspector protocol. This
allows tracking `fetch` calls with an inspector.

PR-URL: #56488
Refs: #53946
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #56493
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Signed-off-by: Daeyeon Jeong <[email protected]>
PR-URL: #56489
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #56479
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
aduh95 and others added 15 commits January 28, 2025 00:27
PR-URL: #56750
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
PR-URL: #56698
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #56755
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Fix the inspector_protocol/roll.py to fit node source directory
structure.

`roll.py` reads the `deps/v8/thrid_party/inspector_protocol/README.v8`
to get the revision of the inspector_protocol that V8 depends on, and
updates the local version to match.

V8's copy of inspector_protocol modifies the namespace of `crdtp`
library and does not export the symbols. So it can not be used outside
of V8.

PR-URL: #56649
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Roll the inspector_protocol library to match V8's inspector_protocol
revision.

Update the node inspector to use the new `crdtp` protocol library.

PR-URL: #56649
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
The `crdtp` library in the inspector_protocol is compiled as a library
and linked to the node executable.

PR-URL: #56649
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
test-global-setters.js was added in
#26882 and hasn't been modified
since. It appears that it avoids strict mode so that unscoped
identifiers are treated as globals, but that's true in strict mode too.
(In sloppy mode, an assignment to an undefined identifier will create a
global, but that's not what this test does. In strict mode, those
assignments will throw an error, which would seem to be what we would
want.)

PR-URL: #56742
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
By its own nature, the function returned by `common.mustSucceed()`
cannot be used as a listener for `'error'` events.

Write errors like `read ECONNRESET` or `write EPIPE`, should be ignored
because the socket might be closed by the other peer while the request
is sent.

Refs: 3caa2c1a005652fdb3e8
PR-URL: #56756
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reduce chances of write errors while the request is sent.

Refs: #56756
PR-URL: #56757
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #56592
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
PR-URL: #56580
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #56259
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Co-authored-by: Llorx <[email protected]>
PR-URL: #56662
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #56795
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Notable changes:

crypto:
  * update root certificates to NSS 3.107 (Node.js GitHub Bot) #56566
fs:
  * (SEMVER-MINOR) allow `exclude` option in globs to accept glob patterns (Daeyeon Jeong) #56489
module:
  * (SEMVER-MINOR) add ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX (Marco Ippolito) #56610
sqlite:
  * (SEMVER-MINOR) support TypedArray and DataView in `StatementSync` (Alex Yang) #56385
src:
  * (SEMVER-MINOR) add --disable-sigusr1 to prevent signal i/o thread (Rafael Gonzaga) #56441
src,worker:
  * (SEMVER-MINOR) add isInternalWorker (Carlos Espa) #56469
test_runner:
  * (SEMVER-MINOR) add TestContext.prototype.waitFor() (Colin Ihrig) #56595
  * (SEMVER-MINOR) add t.assert.fileSnapshot() (Colin Ihrig) #56459
  * (SEMVER-MINOR) add assert.register() API (Colin Ihrig) #56434

PR-URL: #56800
@github-actions github-actions bot added release Issues and PRs related to Node.js releases. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch. labels Jan 28, 2025
@nodejs-github-bot

This comment was marked as off-topic.

@aduh95 aduh95 marked this pull request as ready for review January 28, 2025 11:07
@aduh95 aduh95 requested a review from a team as a code owner January 28, 2025 11:07
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2025

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (9fa6aeb) to head (e296b09).
Report is 7 commits behind head on v23.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            v23.x   #56800      +/-   ##
==========================================
+ Coverage   88.55%   89.23%   +0.68%     
==========================================
  Files         657      663       +6     
  Lines      190741   191947    +1206     
  Branches    36622    36927     +305     
==========================================
+ Hits       168909   171290    +2381     
+ Misses      15003    13528    -1475     
- Partials     6829     7129     +300     
Files with missing lines Coverage Δ
lib/assert.js 99.04% <ø> (+<0.01%) ⬆️
lib/internal/assert/assertion_error.js 95.44% <ø> (+0.07%) ⬆️
lib/internal/assert/myers_diff.js 89.38% <ø> (-0.44%) ⬇️
lib/internal/blob.js 99.80% <ø> (+<0.01%) ⬆️
lib/internal/bootstrap/node.js 99.57% <ø> (+<0.01%) ⬆️
lib/internal/bootstrap/realm.js 96.25% <ø> (+0.21%) ⬆️
.../internal/bootstrap/switches/is_not_main_thread.js 100.00% <ø> (ø)
lib/internal/child_process/serialization.js 95.85% <ø> (+0.12%) ⬆️
lib/internal/console/constructor.js 98.54% <ø> (+0.51%) ⬆️
lib/internal/errors.js 97.46% <ø> (+0.45%) ⬆️
... and 88 more

... and 91 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2025

@aduh95
Copy link
Contributor

aduh95 commented Jan 29, 2025

The release is blocked by nodejs/build#4009, I'll have to postpone it

@ryanaslett
Copy link

@aduh95 nodejs/build#4009 should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases. v23.x v23.x Issues that can be reproduced on v23.x or PRs targeting the v23.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.