[#198] Generate and add "release notes" when distributing new builds on Firebase (staging and production) #270

doannimble · 2023-09-25T05:08:19Z

Close Generate and add "release notes" when distributing new builds on Firebase (staging and production) #198

What happened 👀

Use mikepenz/release-changelog-builder-action to generate change log
Find and use HEAD commit for prudction build
Apply Limit changelog to the latest pull request only for staging
Add changelog-config.json file

Insight 📝

I was trying to use echo "RELEASE_NOTE_CONTENT="$((git log -1 --merges | grep "\[") | grep . && echo "" || echo $(git log -1 --merges --format=%B))"" for staging flow (android and iOS)

and Add echo "RELEASE_NOTE_CONTENT="$(git log --merges --pretty=%B $(git describe --abbrev=0 --tags)..HEAD | grep "\[")"" for production flow (Android only)

But neither of them works (showing empty value)

Trying with `8BitJonny/gh-get-current-pr is better, but it still does not meet our expectations. It is only able to get the PR title/content in raw text.

Proof Of Work 📹

Staging

Production

manh-t · 2023-09-28T08:30:36Z

@doannimble the release note in the PoW contains the last commit message of this PR instead of the title of the PR. I found an issue and commented here. Please kindly check 🙏

luongvo

@doannimble Please clarify the env usage 🙏

.github/workflows/android_deploy_production.yml

.github/workflows/ios_deploy_staging_to_firebase.yml

luongvo · 2023-10-04T02:25:37Z

@doannimble the release note in the PoW contains the last commit message of this PR instead of the title of the PR. I found an issue and commented here. Please kindly check 🙏

@manh-t Thank you for the great insight 👍

However, I just realized that Firebase will add the default release notes as the merge commit message or the working commit message already.

For example, from my working project:

when deploying a build from a merge commit on dev
when deploying a build from a working branch on a commit for testing

I doubt the last commit message from your POW comes from the built-in feature of Firebase CLI, not from your effort with the RELEASE_NOTE_CONTENT env, as I don't see its usage anywhere from the workflow 🤔 @doannimble

Falling back to the merge commit message or the working commit message in case the command can not get the PR title does not make sense here 💭 What do you think @doannimble @manh-t?

luongvo · 2023-10-09T02:35:46Z

@doannimble please plan to have updates on this PR. Thank you 🤗

luongvo · 2023-10-11T08:51:18Z

@doannimble Do you finish the necessary updates on this PR? Should we mark this PR back to Draft?

doannimble · 2023-10-11T08:54:17Z

@doannimble Do you finish the necessary updates on this PR? Should we mark this PR back to Draft?

@luongvo Yes I do. Please help to review and let me know if we need more improvement 🙏

manh-t · 2023-10-13T08:57:33Z

@doannimble we need a new PoW. The current PoW is invalid 🙏

luongvo

Please re-check the script result usage as I don't think it's working properly 🙏

.github/workflows/android_deploy_production.yml

bricks/template/__brick__/{{project_name.snakeCase()}}/ios/fastlane/Fastfile

.../__brick__/{{project_name.snakeCase()}}/.github/workflows/ios_deploy_staging_to_firebase.yml

luongvo

Looks better with https://github.com/8BitJonny/gh-get-current-pr. Please re-check your implementation carefully 🙏

.github/workflows/android_deploy_production.yml

.github/workflows/android_deploy_staging.yml

bricks/template/__brick__/.github/workflows/android_deploy_production.yml

bricks/template/__brick__/.github/workflows/android_deploy_staging.yml

.github/workflows/ios_deploy_staging_to_firebase.yml

bricks/template/__brick__/.github/workflows/ios_deploy_staging_to_firebase.yml

luongvo · 2023-11-01T08:05:15Z

@doannimble I believe we should drop all [Chore] Generate & update sample project commits when rebasing https://github.com/nimblehq/flutter-templates/pull/270/commits 🤓

.github/workflows/android_deploy_production.yml

.github/workflows/android_deploy_staging.yml

luongvo

Please update PR description to align to the new approach & POWs for both staging & production 🙏

.github/workflows/android_deploy_production.yml

bricks/template/__brick__/.github/workflows/android_deploy_production.yml

sample/.github/workflows/ios_deploy_staging_to_firebase.yml

sample/.github/workflows/android_deploy_staging.yml

bricks/template/__brick__/.github/workflows/android_deploy_staging.yml

bricks/template/__brick__/.github/workflows/ios_deploy_staging_to_firebase.yml

luongvo · 2023-11-09T09:14:46Z

Please update PR description to align to the new approach & POWs for both staging & production 🙏
@doannimble 🙏

doannimble · 2023-11-10T08:49:10Z

Please update PR description to align to the new approach & POWs for both staging & production 🙏
@doannimble 🙏

@luongvo Updated 🙏

luongvo

Now all good 👍

manh-t

👏

doannimble changed the title ~~Chore/198 add release note firebase deploy~~ [198] Generate and add "release notes" when distributing new builds on Firebase (staging and production) Sep 25, 2023

doannimble self-assigned this Sep 26, 2023

doannimble marked this pull request as ready for review September 26, 2023 02:38

doannimble requested review from luongvo, manh-t, markgravity, sleepylee, chornerman, hoangnguyen92dn, nmint8m, ducbm051291, thiennguyen0196, kaungkhantsoe, Shayokh144, toby-thanathip and Wadeewee as code owners September 26, 2023 02:38

manh-t mentioned this pull request Sep 28, 2023

Generate and add "release notes" when distributing new builds on Firebase (staging and production) #198

Closed

luongvo reviewed Oct 4, 2023

View reviewed changes

.github/workflows/android_deploy_production.yml Outdated Show resolved Hide resolved

.github/workflows/ios_deploy_staging_to_firebase.yml Outdated Show resolved Hide resolved

luongvo added this to the 1.12.0 milestone Oct 4, 2023

doannimble temporarily deployed to staging October 9, 2023 02:56 — with GitHub Actions Inactive

doannimble requested a review from luongvo October 11, 2023 08:54

luongvo reviewed Oct 25, 2023

View reviewed changes

doannimble force-pushed the chore/198-add-release-note-firebase-deploy branch from 90697ad to c7f17dc Compare October 27, 2023 08:32

doannimble requested a review from luongvo October 27, 2023 08:34

doannimble force-pushed the chore/198-add-release-note-firebase-deploy branch 2 times, most recently from a3a89ec to f393785 Compare October 31, 2023 11:28

doannimble marked this pull request as ready for review October 31, 2023 11:28

doannimble requested a review from luongvo November 1, 2023 02:40

luongvo changed the title ~~[198] Generate and add "release notes" when distributing new builds on Firebase (staging and production)~~ [#198] Generate and add "release notes" when distributing new builds on Firebase (staging and production) Nov 1, 2023

luongvo reviewed Nov 1, 2023

View reviewed changes

doannimble temporarily deployed to staging November 3, 2023 03:40 — with GitHub Actions Inactive

[#198] Add release notes for Android staging/production and iOS staging

ff16640

doannimble force-pushed the chore/198-add-release-note-firebase-deploy branch from 348667a to ff16640 Compare November 3, 2023 04:06

doannimble requested a review from luongvo November 3, 2023 04:15

luongvo reviewed Nov 3, 2023

View reviewed changes

.github/workflows/android_deploy_production.yml Outdated Show resolved Hide resolved

.github/workflows/android_deploy_staging.yml Outdated Show resolved Hide resolved

doannimble force-pushed the chore/198-add-release-note-firebase-deploy branch from b0ef10a to 0b8bb5a Compare November 4, 2023 03:30

luongvo reviewed Nov 6, 2023

View reviewed changes

doannimble requested a review from luongvo November 9, 2023 07:30

[#198] Update change log config path

423b3f1

doannimble force-pushed the chore/198-add-release-note-firebase-deploy branch from 554fcab to 423b3f1 Compare November 10, 2023 07:19

[Chore] Generate & update sample project

630cc79

luongvo approved these changes Nov 10, 2023

View reviewed changes

luongvo mentioned this pull request Nov 10, 2023

Github Action: Generate and add "release notes" when distributing new builds on Firebase (staging and production) nimblehq/android-templates#463

Open

chornerman approved these changes Nov 10, 2023

View reviewed changes

manh-t approved these changes Nov 13, 2023

View reviewed changes

luongvo added type : feature type : chore and removed type : feature labels Nov 13, 2023

markgravity approved these changes Nov 13, 2023

View reviewed changes

luongvo merged commit c9f59c1 into develop Nov 13, 2023

luongvo deleted the chore/198-add-release-note-firebase-deploy branch November 13, 2023 04:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#198] Generate and add "release notes" when distributing new builds on Firebase (staging and production) #270

[#198] Generate and add "release notes" when distributing new builds on Firebase (staging and production) #270

doannimble commented Sep 25, 2023 •

edited

Loading

manh-t commented Sep 28, 2023

luongvo left a comment

luongvo commented Oct 4, 2023

luongvo commented Oct 9, 2023

luongvo commented Oct 11, 2023 •

edited

Loading

doannimble commented Oct 11, 2023

manh-t commented Oct 13, 2023

luongvo left a comment

luongvo left a comment

luongvo commented Nov 1, 2023

luongvo left a comment •

edited

Loading

luongvo commented Nov 9, 2023

doannimble commented Nov 10, 2023

luongvo left a comment

manh-t left a comment

[#198] Generate and add "release notes" when distributing new builds on Firebase (staging and production) #270

[#198] Generate and add "release notes" when distributing new builds on Firebase (staging and production) #270

Conversation

doannimble commented Sep 25, 2023 • edited Loading

What happened 👀

Insight 📝

Proof Of Work 📹

manh-t commented Sep 28, 2023

luongvo left a comment

Choose a reason for hiding this comment

luongvo commented Oct 4, 2023

luongvo commented Oct 9, 2023

luongvo commented Oct 11, 2023 • edited Loading

doannimble commented Oct 11, 2023

manh-t commented Oct 13, 2023

luongvo left a comment

Choose a reason for hiding this comment

luongvo left a comment

Choose a reason for hiding this comment

luongvo commented Nov 1, 2023

luongvo left a comment • edited Loading

Choose a reason for hiding this comment

luongvo commented Nov 9, 2023

doannimble commented Nov 10, 2023

luongvo left a comment

Choose a reason for hiding this comment

manh-t left a comment

Choose a reason for hiding this comment

doannimble commented Sep 25, 2023 •

edited

Loading

luongvo commented Oct 11, 2023 •

edited

Loading

luongvo left a comment •

edited

Loading