[#198] Use change log for production release

nimblehq · Nov 4, 2023 · 0b8bb5a · 0b8bb5a
1 parent ff16640
commit 0b8bb5a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 18 deletions.
diff --git a/.github/workflows/android_deploy_production.yml b/.github/workflows/android_deploy_production.yml
@@ -57,15 +57,15 @@ jobs:
       - name: Build Android apk
         run: flutter build apk --flavor production --release --build-number $GITHUB_RUN_NUMBER
 
-      - name: Get PR information
-        uses: 8BitJonny/[email protected]
-        id: PR
+      - name: Build Changelog
+        id: build_changelog
+        uses: mikepenz/release-changelog-builder-action@v4
 
       - name: Deploy Android Production to Firebase
         uses: wzieba/[email protected]
         with:
           appId: ${{ vars.FIREBASE_ANDROID_APP_ID }}
           serviceCredentialsFileContent: ${{ secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON }}
           groups: ${{ vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS }}
-          releaseNotes: ${{ steps.PR.outputs.pr_body }}
+          releaseNotes: ${{ steps.build_changelog.outputs.changelog }}
           file: build/app/outputs/flutter-apk/app-production-release.apk
diff --git a/bricks/template/__brick__/.github/workflows/android_deploy_production.yml b/bricks/template/__brick__/.github/workflows/android_deploy_production.yml
@@ -51,15 +51,15 @@ jobs:
       - name: Build Android apk
         run: flutter build apk --flavor production --release --build-number $GITHUB_RUN_NUMBER
 
-      - name: Get PR information
-        uses: 8BitJonny/[email protected]
-        id: PR
+      - name: Build Changelog
+        id: build_changelog
+        uses: mikepenz/release-changelog-builder-action@v4
 
       - name: Deploy Android Production to Firebase
         uses: wzieba/[email protected]
         with:
           appId: ${{#mustacheCase}}vars.FIREBASE_ANDROID_APP_ID{{/mustacheCase}}
           serviceCredentialsFileContent: ${{#mustacheCase}}secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON{{/mustacheCase}}
           groups: ${{#mustacheCase}}vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS{{/mustacheCase}}
-          releaseNotes: ${{#mustacheCase}}steps.PR.outputs.pr_body{{/mustacheCase}}
+          releaseNotes: ${{#mustacheCase}}steps.build_changelog.outputs.changelog{{/mustacheCase}}
           file: build/app/outputs/flutter-apk/app-production-release.apk
diff --git a/bricks/template/__brick__/.github/workflows/ios_deploy_staging_to_firebase.yml b/bricks/template/__brick__/.github/workflows/ios_deploy_staging_to_firebase.yml
@@ -64,6 +64,6 @@ jobs:
 
       - name: Deploy to Firebase
         env:
-          RELEASE_NOTE_CONTENT: ${{ steps.PR.outputs.pr_title }}
+          RELEASE_NOTE_CONTENT:${{#mustacheCase}}steps.PR.outputs.pr_title{{/mustacheCase}}
         run: |
           cd ./ios && bundle exec fastlane build_and_upload_staging_app
diff --git a/sample/.github/workflows/android_deploy_production.yml b/sample/.github/workflows/android_deploy_production.yml
@@ -62,4 +62,4 @@ jobs:
           serviceCredentialsFileContent: ${{ secrets.FIREBASE_DISTRIBUTION_CREDENTIAL_JSON }}
           groups: ${{ vars.FIREBASE_DISTRIBUTION_TESTER_GROUPS }}
           releaseNotes: ${{ steps.PR.outputs.pr_body }}
-          file: build/app/outputs/flutter-apk/app-production-debug.apk
+          file: build/app/outputs/flutter-apk/app-production-release.apk
diff --git a/sample/.github/workflows/ios_deploy_staging_to_firebase.yml b/sample/.github/workflows/ios_deploy_staging_to_firebase.yml
@@ -46,17 +46,10 @@ jobs:
         run: |
           echo -e "$ENV" > .env.staging
 
-            - name: Get PR information
+      - name: Get PR information
         uses: 8BitJonny/[email protected]
         id: PR
 
-      - name: Generate release notes
-        id: generate-release-notes
-        env:
-          PR_TITLE: ${{ steps.PR.outputs.pr_title }}
-        run: |
-          echo "RELEASE_NOTE_CONTENT=$PR_TITLE" >> $GITHUB_ENV
-
       - name: Run code generator
         run: flutter packages pub run build_runner build --delete-conflicting-outputs
 
@@ -70,5 +63,7 @@ jobs:
         run: cd ./ios && bundle exec fastlane sync_adhoc_staging_signing
 
       - name: Deploy to Firebase
+        env:
+          RELEASE_NOTE_CONTENT:${{ steps.PR.outputs.pr_title }}
         run: |
           cd ./ios && bundle exec fastlane build_and_upload_staging_app