fix(files_sharing): Stop overwriting the share expiration date with the default expiration date #50192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
nfebe,
skjnldsv,
a team and
szaimen
and removed request for
a team
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
skjnldsv
approved these changes
Jan 15, 2025
|
/compile |
|
Draft until test is added. |
|
Watch out when backporting to stable28, I saw that there are duplicate |
…he default expiration date Signed-off-by: provokateurin <[email protected]>
This should be done as soon as changed, as the value is not passed to API but needs to be tracked internally (e.g. if you quickly press "save"). Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files_sharing/sharing-entry-link-override-expiration-date
branch
from
b976221 to
b55c337
Compare
|
Tests added, needed to fix another bug otherwise test would fail. |
susnux
force-pushed
the
fix/files_sharing/sharing-entry-link-override-expiration-date
branch
from
b55c337 to
6ef6610
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
fix/files_sharing/sharing-entry-link-override-expiration-date
branch
from
6ef6610 to
ddd70c9
Compare
susnux
deleted the
fix/files_sharing/sharing-entry-link-override-expiration-date
branch
This was referenced Jan 15, 2025
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the admin has a default expiration date configured the share expiration date is overwritten every time, even if a different expiration date was selected for the share.
Removing this doesn't cause any problems when creating a new share with the default expiration date, since the date is added in the backend automatically.
Introduced in #49115 and slightly adjusted in #49147.
Checklist