Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(files_sharing): Stop overwriting the share expiration date with the default expiration date #50202

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 15, 2025

Backport of #50192

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate mounted() method needs to be removed

@susnux susnux force-pushed the backport/50192/stable28 branch from f5828fa to 8de745a Compare January 16, 2025 08:04
@susnux susnux requested a review from provokateurin January 16, 2025 08:04
@susnux susnux marked this pull request as ready for review January 16, 2025 08:04
provokateurin and others added 4 commits January 16, 2025 09:06
…he default expiration date

Signed-off-by: provokateurin <[email protected]>
This should be done as soon as changed, as the value is not passed to
API but needs to be tracked internally (e.g. if you quickly press
"save").

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the backport/50192/stable28 branch from 8de745a to 8686524 Compare January 16, 2025 08:07
@AndyScherzinger AndyScherzinger merged commit eac3c5f into stable28 Jan 16, 2025
46 of 47 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/50192/stable28 branch January 16, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants