Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert environment variable name change in installers and scripts #2852

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Oct 24, 2024

This PR reverts changes (introduced in #2812) to environment variable names that are set in our installers (MSI, Nuget, etc.) and in various Linux scripts.

The .NET agent still supports both the "old style" environment variable names (those starting with or containing NEWRELIC_) as well as the "new style" environment variable names (those starting with or containing NEW_RELIC_) as called out in #2812. This change simply reverts our installers, etc. to use the "old" names so that existing public documentation related to installing the .NET agent remains correct.

@tippmar-nr tippmar-nr requested a review from a team as a code owner October 24, 2024 19:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (d312d30) to head (6a4b231).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2852      +/-   ##
==========================================
+ Coverage   81.31%   81.33%   +0.01%     
==========================================
  Files         460      460              
  Lines       29239    29239              
  Branches     3231     3231              
==========================================
+ Hits        23777    23781       +4     
+ Misses       4669     4666       -3     
+ Partials      793      792       -1     
Flag Coverage Δ
Agent 82.23% <ø> (+0.01%) ⬆️
Profiler 73.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the best thing to do under the circumstances.

Copy link
Member

@nrcventura nrcventura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to suppress the warning about using the older environment variable name?

@tippmar-nr
Copy link
Member Author

Do we also need to suppress the warning about using the older environment variable name?

No, I think it's ok to keep it. The old names really are deprecated and we want folks to use the new names; we're just making this change to bridge the gap between our docs and the agent.

@tippmar-nr tippmar-nr merged commit e77683b into main Oct 25, 2024
94 checks passed
@tippmar-nr tippmar-nr deleted the fix/environment-variable-naming-revert branch October 25, 2024 17:58
tippmar-nr added a commit that referenced this pull request Oct 31, 2024
Fixes a syntax error that was introduced in #2852. 

Resolves #2863
tippmar-nr added a commit that referenced this pull request Oct 31, 2024
Fixes a syntax error that was introduced in #2852. 

Resolves #2863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants