-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert environment variable name change in installers and scripts #2852
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2852 +/- ##
==========================================
+ Coverage 81.31% 81.33% +0.01%
==========================================
Files 460 460
Lines 29239 29239
Branches 3231 3231
==========================================
+ Hits 23777 23781 +4
+ Misses 4669 4666 -3
+ Partials 793 792 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably the best thing to do under the circumstances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to suppress the warning about using the older environment variable name?
No, I think it's ok to keep it. The old names really are deprecated and we want folks to use the new names; we're just making this change to bridge the gap between our docs and the agent. |
This PR reverts changes (introduced in #2812) to environment variable names that are set in our installers (MSI, Nuget, etc.) and in various Linux scripts.
The .NET agent still supports both the "old style" environment variable names (those starting with or containing
NEWRELIC_
) as well as the "new style" environment variable names (those starting with or containingNEW_RELIC_
) as called out in #2812. This change simply reverts our installers, etc. to use the "old" names so that existing public documentation related to installing the .NET agent remains correct.