Syntax error in /build/Linux/build/common/setenv.sh

[Lilstritz]

There's a syntax error in the file /build/Linux/build/common/setenv.sh

Description
A recent build in my team's CI pipeline failed with the error /usr/local/newrelic-dotnet-agent/setenv.sh: line 3: syntax error near unexpected token '&&'

Expected Behavior
Build doesn't fail. Syntax is correct.

The problem:
(I believe?) The first semicolon should be removed: https://github.com/newrelic/newrelic-dotnet-agent/blob/main/build/Linux/build/common/setenv.sh#L3

Introduced in #2852

Apologies if I'm missing anything.

[workato-integration]

https://new-relic.atlassian.net/browse/NR-335805

[Lilstritz]

I tried to push a branch with the fix but I got a 403. I've never attempted to contribute to a public repo before so I don't know the rules. In any case, I think / hope this is straightforward enough.

[tippmar-nr]

@Lilstritz Thanks for your report - the fix was easy enough. Next time, you can fork our repo, make a change in a branch on your fork and then open a PR to our repo with the change.

[Lilstritz]

Thanks for the quick turnaround and thanks for the information.

[Lilstritz]

This issue inspired me to add shellcheck to my team's codebase's CI pipelines. I attempted to apply the same change in this codebase, but I ran into some nontrivial shell errors that I have no business meddling with in this codebase.

But in case it interests anybody, applying the check for me was fairly straightforward, and I'll leave the github workflow instructions here in case anybody (with more domain knowledge or confidence) wants to take a shot at cleaning up the shell errors and integrating a shell linter into the CI pipeline.

  shellcheck:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4 
      - run: |
          sudo apt-get update && sudo apt-get install -y shellcheck
          find ${{ github.workspace }} -name "*.sh" -exec shellcheck --severity=error {} +