[1.21.1] Fix root transforms not affecting cullfaces #1627
+3
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes cullfaces specified in standard "elements" models not being affected by root transforms.
Currently, the root transform is only applied to the vertex data of the quads themselves, which causes the cullface of a quad affected by a root transform to use the source element's original cullface instead of the transformed one that would be expected from its final orientation.
The intention of this PR is not to fix the issue where a model transformed by translation or scaling or by a rotation that is not a multiple of 90 degrees has undesired culling from the original or transformed cullfaces (this issue exists without this fix as well).
This issue only affects 1.21.1 and earlier.
Fixes #1623