Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite model loader culling behavior #1623

Open
TBoshoven opened this issue Oct 24, 2024 · 1 comment · May be fixed by #1627
Open

Composite model loader culling behavior #1623

TBoshoven opened this issue Oct 24, 2024 · 1 comment · May be fixed by #1627
Assignees
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error rendering Related to rendering

Comments

@TBoshoven
Copy link
Contributor

Minecraft Version: 1.21.1

NeoForge Version: 21.1.72

Logs: N/A

Steps to Reproduce:

  1. Load my repro mod (release page has a jar if you're particularly trusting)
  2. Give yourself a repro block (/give @p repro:repro_block) and place it in the world
  3. Observe culling behavior when placing solid blocks around it

Description of issue:
When using the neoforge:composite model loader, the child models still have their original cullface logic applied.
This logic will not necessarily be valid as the children are scaled, translated, or as demonstrated here, rotated.

The repro mod demonstrates this issue by means of a composite model with the same child four times in different orientations.
When placing a solid block against one of the sides, all sides are culled.

Image

I imagine it would be hard to make cullface work with arbitrary transformations, but maybe rotation can be done?
While I could obviously just not cull any faces on my child model to solve this issue, I couldn't do that if I was using a vanilla model instead.

@TBoshoven TBoshoven added the triage Needs triaging and confirmation label Oct 24, 2024
@XFactHD XFactHD added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.21.3 Targeted at Minecraft 1.21.3 labels Oct 24, 2024
@XFactHD XFactHD self-assigned this Oct 24, 2024
@XFactHD XFactHD added 1.21.1 Targeted at Minecraft 1.21.1 and removed 1.21.3 Targeted at Minecraft 1.21.3 triage Needs triaging and confirmation labels Oct 24, 2024
@XFactHD
Copy link
Member

XFactHD commented Oct 24, 2024

This issue is not specific to composite models, it's caused by how the root transforms are applied to models in general. This is not an issue anymore in 1.21.3 due to changes in our model loading extensions. I'll open a PR to fix this in 1.21.1 in a moment.

@XFactHD XFactHD linked a pull request Oct 24, 2024 that will close this issue
@XFactHD XFactHD linked a pull request Oct 24, 2024 that will close this issue
@XFactHD XFactHD removed the regression Worked previously but doesn't anymore label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error rendering Related to rendering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants