Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oppgradere deploy action og nøkkelfri deploy #136

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Oppgradere deploy action og nøkkelfri deploy #136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa6e138
Oppgradere deploy action og nøkkelfri deploy
JulieHillRoa Feb 20, 2024
a574aa1
Fjerne apinøkkel_obo også
JulieHillRoa Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-alerts-to-prod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: actions/checkout@v4

- name: Deploy to prod-fss
uses: nais/deploy/actions/deploy@v1
uses: nais/deploy/actions/deploy@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trenger permission her?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nei, men her bruker man en annen key, var litt usikker på om man kunne fjerne den nøkkelen og heller legge inn permission? har du peil?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan prøve å fjerne linje 25, og legge til permission, men vente med å slette nøkkelen i settings?

Copy link
Contributor

@Mathiamu Mathiamu Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Siden den bruker samme action så antar jeg det skal funke på samme måte 🤔 er jeg ganske sikker på at det skal funke på samme måte

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sjekket i portefølje-repo og ja det gikk i alle fall bra haha

env:
APIKEY: ${{ secrets.NAIS_DEPLOY_APIKEY_OBO }}
CLUSTER: prod-fss
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/deploy-til-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,14 @@ jobs:
name: Deploy application to dev
needs: test-build-and-push
runs-on: ubuntu-latest
permissions:
id-token: write
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Deploy application
uses: nais/deploy/actions/deploy@v1
uses: nais/deploy/actions/deploy@v2
env:
APIKEY: ${{ secrets.NAIS_DEPLOY_APIKEY }}
CLUSTER: dev-fss
RESOURCE: .nais/application/application-config-dev.yaml
VAR: image=${{ needs.test-build-and-push.outputs.image }}
10 changes: 6 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,15 @@ jobs:
if: github.ref == 'refs/heads/dev'
needs: test-build-and-push
runs-on: ubuntu-latest
permissions:
id-token: write
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Deploy application
uses: nais/deploy/actions/deploy@v1
uses: nais/deploy/actions/deploy@v2
env:
APIKEY: ${{ secrets.NAIS_DEPLOY_APIKEY }}
CLUSTER: dev-fss
RESOURCE: .nais/application/application-config-dev.yaml
VAR: image=${{ needs.test-build-and-push.outputs.image }}
Expand All @@ -77,14 +78,15 @@ jobs:
if: github.ref == 'refs/heads/master'
needs: test-build-and-push
runs-on: ubuntu-latest
permissions:
id-token: write
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Deploy application
uses: nais/deploy/actions/deploy@v1
uses: nais/deploy/actions/deploy@v2
env:
APIKEY: ${{ secrets.NAIS_DEPLOY_APIKEY }}
CLUSTER: prod-fss
RESOURCE: .nais/application/application-config-prod.yaml
VAR: image=${{ needs.test-build-and-push.outputs.image }}
Expand Down