Oppgradere deploy action og nøkkelfri deploy #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathiamu
reviewed
Feb 20, 2024
| @@ -20,7 +20,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Deploy to prod-fss | |||
| uses: nais/deploy/actions/deploy@v1 | |||
| uses: nais/deploy/actions/deploy@v2 | |||
There was a problem hiding this comment.
nei, men her bruker man en annen key, var litt usikker på om man kunne fjerne den nøkkelen og heller legge inn permission? har du peil?
There was a problem hiding this comment.
Kan prøve å fjerne linje 25, og legge til permission, men vente med å slette nøkkelen i settings?
There was a problem hiding this comment.
Siden den bruker samme action så antar jeg det skal funke på samme måte 🤔 er jeg ganske sikker på at det skal funke på samme måte
There was a problem hiding this comment.
Sjekket i portefølje-repo og ja det gikk i alle fall bra haha
|
Mathiamu
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.