Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

Prefix player_id in Vimeo wrapper to work around bug in current player #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

scottgarner
Copy link

Fix for issue #417.

An update to the Vimeo player on November 20th, 2014 breaks Popcorn support by ignoring numeric values for player_id when firing events. This fix simply prefixes the ID with a string, causing Vimeo player events to return it properly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant