Vimeo Wrapper Not Working?

[menismu]

Issue reported: mozilla#417
Reported by: @scottgarner

@scottgarner
scottgarner commented on 21 Nov 2014
A formerly working Popcorn instance created with HTMLVimeoVideoElement is now totally unresponsive (can't play, won't trigger events), but doesn't throw errors. I'm wondering if Vimeo just pushed a player update that broke something?

When running the HTMLVimeoVideoElement Tests, I don't get past T02, which times out.

Here's my info from the test: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.62 Safari/537.36

I also tested in Chrome and Safari. The Youtube wrapper seems to work fine.

@JohannesHoppe
JohannesHoppe commented on 21 Nov 2014
I'm experiencing the same issue! :-(

@rfernand
rfernand commented on 21 Nov 2014
Same problem here. The play call and the triggers doesn't work. Tried with popcorn-complete.js version 1.3 and then with version 1.5.6.

@scottgarner scottgarner referenced this issue in processing/Processing-Hour-Of-Code on 22 Nov 2014
Closed
Vimeo Player Issues #69
@rjmacarthy
rjmacarthy commented on 22 Nov 2014
I am having the same issues, I assume that vimeo have changed something which is causing the triggers not to work now. Is there any chance that this can be fixed? It appeared to break about two days ago, as I was testing and developing with Vimeo videos the day before...

Thanks.

@scottgarner
scottgarner commented on 22 Nov 2014
Yes, it died for me on the 20th in the middle of working on a project. Looks like the current player version is dated to the 17th, but who knows when they pushed it into production.

https://f.vimeocdn.com/p/2.5.21/js/player.js

The previous version is still up, too, but it's hard to compare them because the minify variables have changed.

@scottgarner
scottgarner commented on 22 Nov 2014
Okay, after some digging it looks like the whole problem is with the player_id sent to identify the player.

Apparently if this id is numeric, the new Vimeo player doesn't return it properly. A quick fix is to use the prefix argument for popcorn.guid() in the Vimeo wrapper code:

playerUID = Popcorn.guid(),

becomes

playerUID = Popcorn.guid("player_"),

@scottgarner scottgarner referenced this issue on 22 Nov 2014
Open
Prefix player_id in Vimeo wrapper to work around bug in current player mozilla#418
@bytebrain
bytebrain commented on 24 Nov 2014
Your patch is not working for me? I'm having the same issues.

@rjmacarthy
rjmacarthy commented on 24 Nov 2014
This worked for me, I have tested it today.

Line 5289 - popcorn-complete.js

Change :

playerUID = Popcorn.guid(),
To:

playerUID = Popcorn.guid("player_"),
If you are using a wrapper, then change the line inside the Vimeo wrapper section.

@bytebrain
bytebrain commented on 24 Nov 2014
The underscore was missing indeed :) Thanks!

@JohannesHoppe
JohannesHoppe commented on 24 Nov 2014
Many thanks, the fix works f0r me! :-)

@tdurand
tdurand commented on 25 Nov 2014
well done !

@atommyb
atommyb commented on 25 Nov 2014
+1 - works for me too.

@OCannings
OCannings commented on 25 Nov 2014
+1 fixes the issue for me