Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bitrisescript): Make workflows accept a dict representing the env variables #64

Merged
merged 1 commit into from
May 8, 2024

Conversation

hneiva
Copy link
Contributor

@hneiva hneiva commented Apr 26, 2024

No description provided.

@hneiva hneiva requested a review from ahal April 26, 2024 21:03
@hneiva hneiva force-pushed the hneiva/bitrise-params branch 2 times, most recently from 3fa834a to 0ab97ae Compare April 29, 2024 18:33
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.47%. Comparing base (facc39b) to head (6163262).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   99.44%   99.47%   +0.02%     
==========================================
  Files           8        8              
  Lines         180      190      +10     
  Branches       27       32       +5     
==========================================
+ Hits          179      189      +10     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/mozilla_taskgraph/worker_types.py Outdated Show resolved Hide resolved
@ahal ahal self-requested a review May 2, 2024 20:31
@hneiva hneiva changed the title feat(bitrisescript): Add global and workflow params feat(bitrisescript): Make workflows accept a dict representing the env variables May 6, 2024
Copy link
Contributor

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@hneiva hneiva merged commit e2ae827 into main May 8, 2024
8 checks passed
@hneiva hneiva deleted the hneiva/bitrise-params branch May 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants