Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXIOS-9096 - (ci) Update bitrisescript task payload #20168

Merged
merged 2 commits into from
May 9, 2024
Merged

Add FXIOS-9096 - (ci) Update bitrisescript task payload #20168

merged 2 commits into from
May 9, 2024

Conversation

hneiva
Copy link
Collaborator

@hneiva hneiva commented May 7, 2024 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

Update bitrisescript task payload to allow for fine-grained settings.
A follow up PR to actually merge the locale tasks will be submitted later.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

DEPENDS ON:
mozilla-releng/scriptworker-scripts#977
mozilla-releng/mozilla-taskgraph#64

@hneiva hneiva force-pushed the hneiva/bitrisescript branch 3 times, most recently from 893f081 to 025dad5 Compare May 7, 2024 20:47
@hneiva hneiva requested a review from ahal May 7, 2024 21:18
@hneiva hneiva changed the title (ci) Update bitrisescript task payload Add FXIOS-9096 - (ci) Update bitrisescript task payload May 7, 2024
@hneiva hneiva marked this pull request as ready for review May 7, 2024 21:19
@hneiva hneiva requested a review from a team as a code owner May 7, 2024 21:19
@hneiva hneiva requested a review from dragosb01 May 7, 2024 21:19
@hneiva hneiva force-pushed the hneiva/bitrisescript branch 2 times, most recently from 487cfe3 to 476ae4c Compare May 9, 2024 18:04
@hneiva hneiva added the Needs Landing (Squash) Label used by mergify to land PR with several commits label May 9, 2024
@clarmso
Copy link
Collaborator

clarmso commented May 9, 2024

Let me reopen the PR to trigger Bitrise.

@clarmso clarmso closed this May 9, 2024
@clarmso clarmso reopened this May 9, 2024
@dataports dataports merged commit a89707d into mozilla-mobile:main May 9, 2024
10 checks passed
@hneiva hneiva deleted the hneiva/bitrisescript branch May 9, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarmso clarmso clarmso approved these changes

@ahal ahal ahal approved these changes

@dragosb01 dragosb01 Awaiting requested review from dragosb01 dragosb01 is a code owner automatically assigned from mozilla-mobile/fxios-automation-1

Assignees
No one assigned
Labels
Needs Landing (Squash) Label used by mergify to land PR with several commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hneiva @clarmso @ahal @dataports