Skip to content

Commit

Permalink
resolved errors, mostly spaces, dots etc. One true error was a mixup …
Browse files Browse the repository at this point in the history
…of el and ella in spanish
  • Loading branch information
leokim-l committed Jun 6, 2024
1 parent 4ce6679 commit 04b025c
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,8 @@ private String ageNotAvailable(PhenopacketSex psex) {
@Override
public String heSheIndividual(PhenopacketSex psex) {
return switch (psex) {
case FEMALE -> "el";
case MALE -> "ella";
case FEMALE -> "ella";
case MALE -> "el";
default -> "la persona";
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ public class PpktPhenotypicFeatureEnglishTest {
private static Stream<PPKtIndividualBase.TestIndividual> testGetIndividualPhenotypicFeatures() {
return Stream.of(
new PPKtIndividualBase.TestIndividual("46 year olf female, infantile onset",
female46yearsInfantileOnset(), new PPKtIndividualBase.TestOutcome.Ok("Cerebellar atrophy and Ataxia")),
female46yearsInfantileOnset(), new PPKtIndividualBase.TestOutcome.Ok("Cerebellar atrophy and Ataxia. ")),
new PPKtIndividualBase.TestIndividual("male 4 months, congenital onset",
male4monthsCongenitalOnset(), new PPKtIndividualBase.TestOutcome.Ok("Postaxial polydactyly"))
male4monthsCongenitalOnset(), new PPKtIndividualBase.TestOutcome.Ok("Postaxial polydactyly. "))
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ public class PpktIndividualGermanTest extends PPKtIndividualBase{

private static Stream<TestIndividual> testGetIndividualDescription() {
return Stream.of(
new TestIndividual("46 year olf female, infantile onset",
female46yearsInfantileOnset(), new TestOutcome.Ok("Die Probandin war eine 46-jährige Frau, die sich im Säuglingsalter mit den folgenden Symptomen vorgestellt hat: ")),
new TestIndividual("46 year old female, infantile onset",
female46yearsInfantileOnset(), new TestOutcome.Ok("Die Patientin war eine 46-jährige Frau, die sich im Säuglingsalter mit den folgenden Symptomen vorgestellt hat: ")),
new TestIndividual("male 4 months, congenital onset",
male4monthsCongenitalOnset(), new TestOutcome.Ok("Der Proband war ein 4 Monate alter Säugling, der sich bei der Geburt mit den folgenden Symptomen vorgestellt hat: ")),
male4monthsCongenitalOnset(), new TestOutcome.Ok("Der Patient war ein 4 Monate alter Säugling, der sich bei der Geburt mit den folgenden Symptomen vorgestellt hat: ")),
new TestIndividual("female, no onset",
femaleNoAge(), new TestOutcome.Ok("Die Patientin stellte sich mit den folgenden Symptomen vor: ")),
new TestIndividual("female, no HPOs",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@ public class PpktIndividualSpanishTest extends PPKtIndividualBase{

private static Stream<TestIndividual> testGetIndividualDescription() {
return Stream.of(
new TestIndividual("46 year olf female, infantile onset",
female46yearsInfantileOnset(), new TestOutcome.Ok("La paciente era mujer de 46 años que se presentaba en el primer año de vida con")),
new TestIndividual("46 year old female, infantile onset",
female46yearsInfantileOnset(), new TestOutcome.Ok("La paciente era mujer de 46 años que se presentó en el primer año de vida con")),
new TestIndividual("male 4 months, congenital onset",
male4monthsCongenitalOnset(), new TestOutcome.Ok("El paciente era un bebé de 4 meses que se presentaba al nacer con")),
male4monthsCongenitalOnset(), new TestOutcome.Ok("El paciente era un bebé de 4 meses que se presentó al nacer con")),
new TestIndividual("female, no onset",
femaleNoAge(), new TestOutcome.Ok("La paciente se presentaba con")),
femaleNoAge(), new TestOutcome.Ok("La paciente se presentó con")),
new TestIndividual("female, no HPOs",
femaleNoHPOs(), new TestOutcome.Error(() -> new PhenolRuntimeException("No HPO annotations"))),
new TestIndividual("unknown sex, no 4mo",
unknownSex4MonthOnset(), new TestOutcome.Ok("El paciente se presentaba en la niñez con"))
unknownSex4MonthOnset(), new TestOutcome.Ok("El paciente se presentó en la niñez con"))
);
}

Expand All @@ -56,11 +56,11 @@ void testEvaluateExpression(TestIndividual testCase) {
private static Stream<TestIdvlHeShe> testGetPPKtSex() {
return Stream.of(
new TestIdvlHeShe("female",
PhenopacketSex.FEMALE, new TestOutcome.Ok("she")),
PhenopacketSex.FEMALE, new TestOutcome.Ok("ella")),
new TestIdvlHeShe("male",
PhenopacketSex.MALE, new TestOutcome.Ok("he")),
PhenopacketSex.MALE, new TestOutcome.Ok("el")),
new TestIdvlHeShe("proband",
PhenopacketSex.UNKNOWN, new TestOutcome.Ok("the individual"))
PhenopacketSex.UNKNOWN, new TestOutcome.Ok("la persona"))
);
}

Expand All @@ -84,13 +84,13 @@ void testPPKtSex(TestIdvlHeShe testCase) {
private static Stream<TestIdvlAtAge> testIndlAtAge() {
return Stream.of(
new TestIdvlAtAge("congenital",
congenital, new TestOutcome.Ok("At birth")),
congenital, new TestOutcome.Ok("Al nacer")),
new TestIdvlAtAge("infantile",
infantile, new TestOutcome.Ok("During the infantile period")),
infantile, new TestOutcome.Ok("Durante el período infantil")),
new TestIdvlAtAge("childhood age",
childhood, new TestOutcome.Ok("During childhood")),
childhood, new TestOutcome.Ok("Durante la infancia")),
new TestIdvlAtAge("46 years old",
p46y, new TestOutcome.Ok("At an age of 46 years"))
p46y, new TestOutcome.Ok("A la edad de 46 años"))
);
}

Expand Down

0 comments on commit 04b025c

Please sign in to comment.