Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mondo namespace update #133

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Mondo namespace update #133

merged 1 commit into from
Sep 19, 2024

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Sep 9, 2024

Updates

Mondo namespace update

  • Add missing prefix map / synchronize curie_map.yaml with namespaces.py. Add missing MONDONS prefix map.

Background & additional info

I was looking at omim.ttl and I expected to see something like MONDONS instead of ns1, which is what I saw:

@prefix HGNC_symbol: <https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/> .
@prefix IAO: <http://purl.obolibrary.org/obo/IAO_> .
@prefix MONDO: <http://purl.obolibrary.org/obo/MONDO_> .
@prefix OMIM: <https://omim.org/entry/> .
@prefix OMIMPS: <https://omim.org/phenotypicSeries/PS> .
...
@prefix ns1: <http://purl.obolibrary.org/obo/mondo#> .
...
ns1:omim_included a owl:AnnotationProperty .
...
OMIM:103100 a owl:Class ;
    ns1:omim_included "holmes-adie syndrome" ;
    ...

I made an update to make curie_map.yaml consistent with namespaces.py:

MONDONS = Namespace('http://purl.obolibrary.org/obo/mondo#')

In omim.owl(RDF/XML) this doesn't matter because it uses URIs instead of CURIEs. AFAIK, this doesn't have any effect that matters other than consistency when looking at omim.ttl, which is not a release file. But I'm not 100% sure. So we could leave this open for future examination, or just close it, if we're worried about potential side effects.

Related:

- Add missing prefix map / synchronize `curie_map.yaml` with `namespaces.py`. Add missing MONDONS prefix map.
Copy link
Contributor

@twhetzel twhetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joeflack4 joeflack4 merged commit af28f0e into main Sep 19, 2024
@joeflack4 joeflack4 deleted the mondo-ns branch September 19, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants