-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back oak and phenio (text annotator) #497
Conversation
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Madan has updated the backend to provide the proper format, tested locally and integrates with the frontend nicely, I'll add some fixture data tomorrow. One thing I noticed - the API doesn't know how to handle line breaks. |
For best UX, I think newlines should be preserved. Imagine uploading several separated paragraphs, then getting back a long blob of text. Harder to find the start of sections you want to look at. I could do some work-arounds and trickery to remember the newlines and re-insert them after the response, but I think it'd be better to have the backend preserve the newlines (and any whitespace in general). |
yeah i think that makes sense too. sweet, we'll look at getting that functionality into the backend! |
So i'm ... closer? but clearly |
The results get shown in a |
See line 604 in the text-annotator.json fixture in this branch for an example. And the mock on the pr preview: https://deploy-preview-497--monarch-app.netlify.app/explore?mock=true#text-annotator |
Closes #234