Replace CuriesService with direct usage of curies.Converter
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for monarch-app canceled.
|
|
apologies this seems to have gotten lost in the weeds! @cthoyt would you be willing to take a look at the merge conflict? also just wondering - does the issue we ran into with 0.2.0 apply here, or should this work with 0.1.7 and/or will it require any changes when we update after resolving that? |
|
Merge fixed. We shouldn't be running into any version related issues due to this change |
Add `get_uri` entity util back in for tests to pass
glass-ships
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #486 by fully replacing the CuriesService class and all functionality that makes thin wrappers around
curies.Converterwith direct usage.