Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds field for using OIDC authentication to mount S3 buckets #2775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

Adds field for using OIDC authentication to mount S3 buckets #2775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modal/cloud_bucket_mount.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ def f():
# If the bucket is publicly accessible, the secret is unnecessary and can be omitted.
secret: Optional[_Secret] = None

# Role ARN used for using OIDC authentication to access a cloud bucket.
oidc_auth_role_arn: Optional[str] = None

read_only: bool = False
requester_pays: bool = False

Expand Down Expand Up @@ -155,6 +158,7 @@ def cloud_bucket_mounts_to_proto(mounts: list[tuple[str, _CloudBucketMount]]) ->
bucket_type=bucket_type,
requester_pays=mount.requester_pays,
key_prefix=key_prefix,
oidc_auth_role_arn=mount.oidc_auth_role_arn,
)
cloud_bucket_mounts.append(cloud_bucket_mount)

Expand Down
1 change: 1 addition & 0 deletions modal_proto/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,7 @@ message CloudBucketMount {
bool requester_pays = 6;
optional string bucket_endpoint_url = 7;
optional string key_prefix = 8;
optional string oidc_auth_role_arn = 9;
}

message ContainerArguments { // This is used to pass data from the worker to the container
Expand Down
Loading