Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds field for using OIDC authentication to mount S3 buckets #2775

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

2022tgoel
Copy link
Contributor

@2022tgoel 2022tgoel commented Jan 17, 2025

Describe your changes

  • Provide Linear issue reference (e.g. MOD-1234) if available.
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

  • Adds a new oidc_auth_role_arn field to CloudBucketMount for using OIDC authentication to create the mountpoint.

@2022tgoel 2022tgoel force-pushed the tarushii/s3mount_oidc branch from efd8683 to 0cd7f07 Compare January 17, 2025 17:10
@2022tgoel 2022tgoel requested a review from mwaskom January 17, 2025 17:10
Copy link
Member

@luiscape luiscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants