Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest vcpkg build #4717

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Update to latest vcpkg build #4717

merged 3 commits into from
Jun 9, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Apr 6, 2022 •
edited
Loading

This updates the build environment foe windows and MacOs to the latest vcpkg build.
This update brings many library updates.

@daschuer daschuer marked this pull request as draft April 7, 2022 07:36
@daschuer
Copy link
Member Author

daschuer commented Apr 7, 2022

This is failing due to a qtkeychain issue fixed here: microsoft/vcpkg#24013

@daschuer daschuer mentioned this pull request Apr 14, 2022
Merged
@daschuer
Copy link
Member Author

The upstream fix is merged, waiting until mixxxdj/vcpkg#42 is merged.

@github-actions github-actions bot added the build label Apr 21, 2022
@daschuer daschuer mentioned this pull request Apr 21, 2022
Closed
@daschuer
Copy link
Member Author

daschuer commented Jun 1, 2022

Now waiting for microsoft/vcpkg#25018

@daschuer daschuer mentioned this pull request Jun 1, 2022
Closed
@daschuer
Devendor FindSQLite3.cmake
23c87d1 
It is part of CMake since 3.13 and defines SQLite::SQLite3, without 3
@daschuer
Update to latest vcpkg build
fbabbbc 
Also set VCPKG_TARGET_TRIPLET and VCPKG_DEFAULT_HOST_TRIPLET to
x64-osx-min10.12 this is required for the new environment and also
prevents to go to crosscompile mode
@daschuer daschuer marked this pull request as ready for review June 8, 2022 20:48
@daschuer
Copy link
Member Author

daschuer commented Jun 8, 2022

Hey this is finally working now. Who is able to do y smoke test on windows or mac?
The artifacts can be found here:
https://github.com/mixxxdj/mixxx/actions/runs/2463814609

@JoergAtGithub
Copy link
Member

The Windows build from the artifacts doesn't start up:
grafik

@daschuer daschuer marked this pull request as draft June 9, 2022 05:21
@daschuer daschuer marked this pull request as ready for review June 9, 2022 20:36
@daschuer
Copy link
Member Author

daschuer commented Jun 9, 2022

The windows installer is not twice as big and should include the DLLs. @JoergAtGithub can you do another test?

@JoergAtGithub
Copy link
Member

JoergAtGithub commented Jun 9, 2022 •
edited
Loading

The version from the artifacts works now!
But I noticed more CPU load and more buffer underruns than with my own builds using the old buildenv - not a reliable measurement. Otherwise, everything works flawless.

@fwcd
Copy link
Member

fwcd commented Jun 9, 2022

I can confirm that the macOS build seems to work fine, at least from my limited testing under Rosetta.

@daschuer
Copy link
Member Author

daschuer commented Jun 9, 2022

Great, thank you for your testing. @Swiftb0y: merge?

@fwcd
Copy link
Member

fwcd commented Jun 9, 2022 •
edited
Loading

Hm, something's strange with the macOS version, I cannot drag multiple tracks... I'll check whether the current main build has the same problem.

Edit: Current main has the same issue. More precisely the issue is that once I start dragging multiple tracks, nothing happens. Worse, after the attempt, even trying to drag single tracks does nothing.

Edit 2: I could reproduce this issue both on Intel and ARM Macs. Since this problem seems to be unrelated to this PR, it's probably not a blocker, but perhaps still something worth investigating.

@Swiftb0y
Copy link
Member

Swiftb0y commented Jun 9, 2022

We'd appreciate if you report the track dragging issue on our bugtracker. Thank you.

Swiftb0y
Swiftb0y approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Swiftb0y Swiftb0y merged commit c5d99b8 into mixxxdj:main Jun 9, 2022
@daschuer daschuer mentioned this pull request Jun 11, 2022
Merged
@JoergAtGithub JoergAtGithub mentioned this pull request Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daschuer @JoergAtGithub @fwcd @Swiftb0y