Devendor FindSQLite3.cmake

[daschuer]

It is part of CMake since 3.13 and defines SQLite::SQLite3, without 3

https://cmake.org/cmake/help/latest/module/FindSQLite3.html

[ronso0]

no comment on the code change, but macOS builds fail.

[daschuer]

Mmm that's strange, I have no idea where 'SQLite3::SQLite3' is comming from on Mac

 CMake Error at /Users/runner/buildenv/mixxx-deps-2.4-x64-osx-058063e/scripts/buildsystems/vcpkg.cmake:538 (_add_executable):
  Target "mixxx-test" links to target "SQLite3::SQLite3" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:1571 (add_executable)

[Be-ing]

It was your choice to reject a fully working solution. That code hasn't disappeared...

[daschuer]

This PR will succeed, once we have switched to the environment including this: mixxxdj/vcpkg#27

[Be-ing]

No, it won't, because you're creating a circular dependency. Again, this was already resolved but you rejected the solution.

mixxxdj/vcpkg#27 was never intended to be used separately from #4432. I don't know why you insist on learning this the hard way.

[Holzhaus]

I'll mark this as draft until all CI checks are green.

[daschuer]

This depends on mixxxdj/vcpkg#38

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[daschuer]

There is a single prerequisite missing, merging from upstream vcpkg: mixxxdj/vcpkg#41
Can one have a look?

[daschuer]

This needs to become part of #4717 to fix the build failure.