-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devendor FindSQLite3.cmake #4569
Conversation
no comment on the code change, but macOS builds fail. |
Mmm that's strange, I have no idea where 'SQLite3::SQLite3' is comming from on Mac
|
It was your choice to reject a fully working solution. That code hasn't disappeared... |
This PR will succeed, once we have switched to the environment including this: mixxxdj/vcpkg#27 |
No, it won't, because you're creating a circular dependency. Again, this was already resolved but you rejected the solution. mixxxdj/vcpkg#27 was never intended to be used separately from #4432. I don't know why you insist on learning this the hard way. |
I'll mark this as draft until all CI checks are green. |
This depends on mixxxdj/vcpkg#38 |
This PR is marked as stale because it has been open 90 days with no activity. |
There is a single prerequisite missing, merging from upstream vcpkg: mixxxdj/vcpkg#41 |
It is part of CMake since 3.13 and defines SQLite::SQLite3, without 3
This needs to become part of #4717 to fix the build failure. |
It is part of CMake since 3.13 and defines SQLite::SQLite3, without 3
https://cmake.org/cmake/help/latest/module/FindSQLite3.html