Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix review plugin and SDK error handling #548

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix review plugin and SDK error handling #548

merged 2 commits into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. feat: rust sdk sends error gRPC message on internal error 

    This commit addresses an outstanding bug in the plugin Rust SDK.
Previously, the SDK would print when an erorr occurred during
`handle_session()`, which executes a query, but it did not send an
"error" gRPC message to Hipcheck core, causing analysis to hang while
waiting for a message that would not come. This commit cleans up the
handling and logging of plugin-side internal errors.
    @j-lanson
    j-lanson committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c10585a View commit details
    Browse the repository at this point in the history

  2. fix: review plugin default policy and return type

    @j-lanson
    j-lanson committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b2b617e View commit details
    Browse the repository at this point in the history