fix review plugin and SDK error handling #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses an outstanding bug in the plugin Rust SDK. Previously, the SDK would print when an erorr occurred during `handle_session()`, which executes a query, but it did not send an "error" gRPC message to Hipcheck core, causing analysis to hang while waiting for a message that would not come. This commit cleans up the handling and logging of plugin-side internal errors.
j-lanson
added
type: bug
j-lanson
changed the title
j-lanson
force-pushed
the
jlanson/fix-review-plugin
branch
from
c773393
to
b2b617e
Compare
mchernicoff
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #547 . Resolves #503 .
Separated into two commits - one fixes the rust SDK's handling of errors, the other updates the review plugin to run properly.