Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct remote centroids path in clustering compaction #39399

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from
Open

fix: correct remote centroids path in clustering compaction #39399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/core/src/clustering/KmeansClustering.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,20 +58,20 @@
return cluster_result_;
}

// ut
inline std::string
GetRemoteCentroidsObjectPrefix() const {
auto index_meta_ = file_manager_->GetIndexMeta();
auto field_meta_ = file_manager_->GetFieldDataMeta();
boost::filesystem::path prefix =
file_manager_->GetChunkManager()->GetRootPath();
boost::filesystem::path path =
boost::filesystem::path path = std::string(ANALYZE_ROOT_PATH);
boost::filesystem::path path1 =

Check warning on line 68 in internal/core/src/clustering/KmeansClustering.h

View check run for this annotation

Codecov / codecov/patch

internal/core/src/clustering/KmeansClustering.h#L67-L68 

Added lines #L67 - L68 were not covered by tests
std::to_string(index_meta_.build_id) + "/" +
std::to_string(index_meta_.index_version) + "/" +
std::to_string(field_meta_.collection_id) + "/" +
std::to_string(field_meta_.partition_id) + "/" +
std::to_string(field_meta_.field_id);
return (prefix / path).string();
return (prefix / path / path1).string();

Check warning on line 74 in internal/core/src/clustering/KmeansClustering.h

View check run for this annotation

Codecov / codecov/patch

internal/core/src/clustering/KmeansClustering.h#L74 

Added line #L74 was not covered by tests
}

inline std::string
Expand Down
Loading