Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct remote centroids path in clustering compaction #39399

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

chasingegg
Copy link
Contributor

issue: #39353
pr: #39398

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 17, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 17, 2025
@xiaocai2333
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (f704e3e) to head (717021b).

Files with missing lines Patch % Lines
internal/core/src/clustering/KmeansClustering.h 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39399       +/-   ##
===========================================
+ Coverage   69.49%   81.03%   +11.53%     
===========================================
  Files         300     1404     +1104     
  Lines       26767   197573   +170806     
===========================================
+ Hits        18601   160095   +141494     
- Misses       8166    31865    +23699     
- Partials        0     5613     +5613     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.48% <0.00%> (-0.01%) ⬇️
Go 83.00% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/clustering/KmeansClustering.h 0.00% <0.00%> (ø)

... and 1104 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants