Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip erase field if index build on PK field #39370

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

congqixia
Copy link
Contributor

Related to #39339

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Jan 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (0461ddf) to head (16b62e5).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39370       +/-   ##
===========================================
+ Coverage   69.47%   81.00%   +11.53%     
===========================================
  Files         300     1407     +1107     
  Lines       26903   198527   +171624     
===========================================
+ Hits        18692   160826   +142134     
- Misses       8211    32041    +23830     
- Partials        0     5660     +5660     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.48% <75.00%> (+<0.01%) ⬆️
Go 82.94% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 84.08% <100.00%> (+0.01%) ⬆️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.93% <50.00%> (+0.07%) ⬆️

... and 1107 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 17, 2025
@czs007 czs007 requested review from czs007 and removed request for bigsheeper and xiaocai2333 January 17, 2025 12:29
@czs007
Copy link
Collaborator

czs007 commented Jan 17, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7cac87c into milvus-io:master Jan 17, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants