-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.5] Skip erase field if index build on PK field #39371
base: 2.5
Are you sure you want to change the base?
Conversation
Related to milvus-io#39339 Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@congqixia go-sdk check failed, comment |
@congqixia E2e jenkins job failed, comment |
@congqixia cpp-unit-test check failed, comment |
Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #39371 +/- ##
===========================================
+ Coverage 69.50% 81.01% +11.50%
===========================================
Files 300 1404 +1104
Lines 26763 197533 +170770
===========================================
+ Hits 18602 160034 +141432
- Misses 8161 31876 +23715
- Partials 0 5623 +5623
|
/hold |
Cherry pick from master
pr: #39370
Related to #39339