Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Skip erase field if index build on PK field #39371

Open
wants to merge 4 commits into
base: 2.5
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #39370
Related to #39339

@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. approved labels Jan 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (e68d161) to head (2210e67).
Report is 10 commits behind head on 2.5.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39371       +/-   ##
===========================================
+ Coverage   69.50%   81.01%   +11.50%     
===========================================
  Files         300     1404     +1104     
  Lines       26763   197533   +170770     
===========================================
+ Hits        18602   160034   +141432     
- Misses       8161    31876    +23715     
- Partials        0     5623     +5623     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.50% <75.00%> (+<0.01%) ⬆️
Go 82.98% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 84.05% <100.00%> (+0.03%) ⬆️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.93% <50.00%> (+0.07%) ⬆️

... and 1105 files with indirect coverage changes

@congqixia
Copy link
Contributor Author

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/hold kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants