Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] remove param num_build_thread #39341

Merged
merged 1 commit into from
Jan 16, 2025

remove num_build_thread param

cb54367
Select commit
Loading
Failed to load commit list.
Merged

fix: [2.5] remove param num_build_thread #39341

remove num_build_thread param
cb54367
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 0s

81.07% (target 77.00%)

View this Pull Request on Codecov

81.07% (target 77.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (4cb47b3) to head (cb54367).
Report is 5 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39341      +/-   ##
==========================================
+ Coverage   81.04%   81.07%   +0.02%     
==========================================
  Files        1404     1404              
  Lines      197402   197454      +52     
==========================================
+ Hits       159983   160080      +97     
+ Misses      31799    31759      -40     
+ Partials     5620     5615       -5     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.50% <ø> (ø)
Go 83.05% <ø> (+0.03%) ⬆️
Files with missing lines Coverage Δ
pkg/util/paramtable/knowhere_param.go 83.13% <ø> (-0.21%) ⬇️

... and 45 files with indirect coverage changes