Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] remove param num_build_thread #39341

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Jan 16, 2025

issue: #39090
pr: #39340

Signed-off-by: xianliang.li <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 16, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@foxspy Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added this to the 2.5.4 milestone Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (4cb47b3) to head (cb54367).
Report is 6 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39341      +/-   ##
==========================================
+ Coverage   81.04%   81.07%   +0.02%     
==========================================
  Files        1404     1404              
  Lines      197402   197454      +52     
==========================================
+ Hits       159983   160080      +97     
+ Misses      31799    31759      -40     
+ Partials     5620     5615       -5     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.50% <ø> (ø)
Go 83.05% <ø> (+0.03%) ⬆️
Files with missing lines Coverage Δ
pkg/util/paramtable/knowhere_param.go 83.13% <ø> (-0.21%) ⬇️

... and 45 files with indirect coverage changes

@liliu-z
Copy link
Member

liliu-z commented Jan 16, 2025

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 16, 2025
@sre-ci-robot sre-ci-robot merged commit e752059 into milvus-io:2.5 Jan 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants