Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [2.5] root privileges can be customized #39324

Merged
merged 1 commit into from
Jan 16, 2025

feat: [2.5] root privileges can be customized

82f0423
Select commit
Loading
Failed to load commit list.
Merged

feat: [2.5] root privileges can be customized #39324

feat: [2.5] root privileges can be customized
82f0423
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 16, 2025 in 0s

81.04% (target 77.00%)

View this Pull Request on Codecov

81.04% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (1602390) to head (82f0423).
Report is 2 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/meta_cache_testonly.go 50.00% 8 Missing and 2 partials ⚠️
internal/rootcoord/root_coord.go 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #39324   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files        1403     1404    +1     
  Lines      197406   197436   +30     
=======================================
+ Hits       159986   160011   +25     
- Misses      31797    31801    +4     
- Partials     5623     5624    +1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.50% <ø> (ø)
Go 83.02% <60.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/privilege_interceptor.go 82.63% <100.00%> (-2.11%) ⬇️
pkg/util/paramtable/component_param.go 98.40% <100.00%> (+<0.01%) ⬆️
internal/rootcoord/root_coord.go 89.90% <20.00%> (-0.15%) ⬇️
internal/proxy/meta_cache_testonly.go 50.00% <50.00%> (ø)

... and 22 files with indirect coverage changes