Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [2.5] root privileges can be customized #39324

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jan 16, 2025

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 16, 2025
Copy link
Contributor

mergify bot commented Jan 16, 2025

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Jan 16, 2025

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Jan 16, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SimFG
Copy link
Contributor Author

SimFG commented Jan 16, 2025

/run-cpu-e2e

@SimFG
Copy link
Contributor Author

SimFG commented Jan 16, 2025

rerun go-sdk

@SimFG
Copy link
Contributor Author

SimFG commented Jan 16, 2025

rerun cpp-unit-test

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (1602390) to head (82f0423).
Report is 3 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/meta_cache_testonly.go 50.00% 8 Missing and 2 partials ⚠️
internal/rootcoord/root_coord.go 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #39324   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files        1403     1404    +1     
  Lines      197406   197436   +30     
=======================================
+ Hits       159986   160011   +25     
- Misses      31797    31801    +4     
- Partials     5623     5624    +1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.50% <ø> (ø)
Go 83.02% <60.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/privilege_interceptor.go 82.63% <100.00%> (-2.11%) ⬇️
pkg/util/paramtable/component_param.go 98.40% <100.00%> (+<0.01%) ⬆️
internal/rootcoord/root_coord.go 89.90% <20.00%> (-0.15%) ⬇️
internal/proxy/meta_cache_testonly.go 50.00% <50.00%> (ø)

... and 22 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 16, 2025
@sre-ci-robot sre-ci-robot merged commit 4cb47b3 into milvus-io:2.5 Jan 16, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants