Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Add primary field name in SearchResult and QueryResults #39220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: Add primary field name in SearchResult and QueryResults #39220

wants to merge 1 commit into from
+21 −14

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Jan 13, 2025

issue: #39219

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels Jan 13, 2025
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Jan 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 13, 2025
This was referenced Jan 13, 2025
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (3e788f0) to head (265749e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task_query.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #39220   +/-   ##
=======================================
  Coverage   81.17%   81.17%           
=======================================
  Files        1399     1399           
  Lines      197583   197590    +7     
=======================================
+ Hits       160386   160395    +9     
+ Misses      31572    31565    -7     
- Partials     5625     5630    +5
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.70% <ø> (ø)
Go 83.11% <42.85%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/task_search.go 76.37% <100.00%> (+0.02%) ⬆️
internal/proxy/task_query.go 80.22% <33.33%> (-0.53%) ⬇️

... and 35 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 13, 2025
@czs007 czs007 force-pushed the add_primary_field_name branch from 31bf60b to 265749e Compare January 14, 2025 04:05
@sre-ci-robot sre-ci-robot added area/test sig/testing size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 14, 2025
@mergify mergify bot removed the ci-passed label Jan 14, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 14, 2025

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator Author

czs007 commented Jan 14, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 14, 2025

@czs007 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia
congqixia approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Jan 14, 2025
@czs007
enhance: Add primary field name in SearchResult and QueryResults (#39222
99a8274 
)

pr: #39220
issue: #39219

Signed-off-by: zhenshan.cao <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Jan 14, 2025
@czs007
enhance: Add primary field name in SearchResult and QueryResults (#39223
3474c59 
)

issue: #39220
pr: #39220

Signed-off-by: zhenshan.cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@congqixia congqixia

Labels
approved area/dependency Pull requests that update a dependency file area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@czs007 @sre-ci-robot @congqixia