Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add primary field name in SearchResult and QueryResults #39222

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

czs007
Copy link
Collaborator

@czs007 czs007 commented Jan 13, 2025

pr: #39220
issue: #39219

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/S Denotes a PR that changes 10-29 lines. approved labels Jan 13, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (a1b8bc7) to head (7f070f1).
Report is 8 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/task_query.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39222       +/-   ##
===========================================
+ Coverage   69.54%   81.08%   +11.54%     
===========================================
  Files         294     1394     +1100     
  Lines       26463   196514   +170051     
===========================================
+ Hits        18403   159342   +140939     
- Misses       8060    31575    +23515     
- Partials        0     5597     +5597     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.53% <ø> (-0.01%) ⬇️
Go 83.05% <42.85%> (∅)
Files with missing lines Coverage Δ
internal/proxy/task_search.go 76.37% <100.00%> (ø)
internal/proxy/task_query.go 80.22% <33.33%> (ø)

... and 1113 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 13, 2025
@czs007
Copy link
Collaborator Author

czs007 commented Jan 14, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 14, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator Author

czs007 commented Jan 14, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 14, 2025

@czs007 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007 czs007 force-pushed the add_primary_field_2.5 branch from bc55a6d to 7f070f1 Compare January 14, 2025 04:03
@sre-ci-robot sre-ci-robot added area/test sig/testing size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 14, 2025
@mergify mergify bot added ci-passed and removed ci-passed labels Jan 14, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 99a8274 into milvus-io:2.5 Jan 14, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants