Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build text index when loading field data (#39070) #39113

Merged
merged 1 commit into from
Jan 9, 2025

fix: build text index when loading field data (#39070)

f14c907
Select commit
Loading
Failed to load commit list.
Merged

fix: build text index when loading field data (#39070) #39113

fix: build text index when loading field data (#39070)
f14c907
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

81.07% (target 77.00%)

View this Pull Request on Codecov

81.07% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (ef40022) to head (f14c907).
Report is 36 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/index/TextMatchIndex.cpp 76.19% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39113      +/-   ##
==========================================
+ Coverage   81.05%   81.07%   +0.01%     
==========================================
  Files        1383     1384       +1     
  Lines      195501   195620     +119     
==========================================
+ Hits       158466   158596     +130     
+ Misses      31461    31451      -10     
+ Partials     5574     5573       -1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.54% <80.76%> (+0.09%) ⬆️
Go 83.04% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentGrowingImpl.cpp 82.80% <100.00%> (+2.10%) ⬆️
internal/core/src/index/TextMatchIndex.cpp 44.88% <76.19%> (+4.24%) ⬆️

... and 76 files with indirect coverage changes