Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build text index when loading field data (#39070) #39113

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

SpadeA-Tang
Copy link
Contributor

fix: #39053 may fix #38644 which could be caused by #39053


@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 9, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 9, 2025
Copy link
Contributor

mergify bot commented Jan 9, 2025

@SpadeA-Tang Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (ef40022) to head (f14c907).
Report is 36 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/index/TextMatchIndex.cpp 76.19% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39113      +/-   ##
==========================================
+ Coverage   81.05%   81.07%   +0.01%     
==========================================
  Files        1383     1384       +1     
  Lines      195501   195620     +119     
==========================================
+ Hits       158466   158596     +130     
+ Misses      31461    31451      -10     
+ Partials     5574     5573       -1     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.54% <80.76%> (+0.09%) ⬆️
Go 83.04% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentGrowingImpl.cpp 82.80% <100.00%> (+2.10%) ⬆️
internal/core/src/index/TextMatchIndex.cpp 44.88% <76.19%> (+4.24%) ⬆️

... and 76 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 9, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 9, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SpadeA-Tang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f70262c into milvus-io:2.5 Jan 9, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants