Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: skip load bm25 sparse row data #39078

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

skip load bm25 field row data

3bb9719
Select commit
Loading
Failed to load commit list.
Open

enhance: skip load bm25 sparse row data #39078

skip load bm25 field row data
3bb9719
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 0s

80.99% (target 77.00%)

View this Pull Request on Codecov

80.99% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 80.99%. Comparing base (228bff5) to head (3bb9719).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment_loader.go 0.00% 14 Missing ⚠️
internal/querynodev2/segments/segment.go 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39078       +/-   ##
===========================================
+ Coverage   69.48%   80.99%   +11.51%     
===========================================
  Files         300     1408     +1108     
  Lines       26904   198585   +171681     
===========================================
+ Hits        18693   160842   +142149     
- Misses       8211    32076    +23865     
- Partials        0     5667     +5667     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.48% <ø> (ø)
Go 82.93% <23.07%> (∅)
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment.go 67.46% <50.00%> (ø)
internal/querynodev2/segments/segment_loader.go 70.89% <0.00%> (ø)

... and 1106 files with indirect coverage changes