Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: skip load bm25 sparse row data #39078

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jan 8, 2025

Skip load row data of bm25 sparse field, because it's forbidden to return.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 8, 2025
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (bca2a62) to head (6421d19).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment_loader.go 0.00% 14 Missing ⚠️
internal/querynodev2/segments/segment.go 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39078       +/-   ##
===========================================
+ Coverage   69.63%   82.83%   +13.19%     
===========================================
  Files         299     1107      +808     
  Lines       26807   171646   +144839     
===========================================
+ Hits        18668   142182   +123514     
- Misses       8139    23799    +15660     
- Partials        0     5665     +5665     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core ∅ <ø> (∅)
Go 82.96% <23.07%> (∅)
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment.go 67.46% <50.00%> (ø)
internal/querynodev2/segments/segment_loader.go 70.73% <0.00%> (ø)

... and 1404 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 10, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 13, 2025
@aoiasd aoiasd changed the title enhance: mark bm25 sparse field as has row data to skip load row data enhance: skip load bm25 sparse row data Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 13, 2025
Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 13, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 14, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 16, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants