skip load bm25 field row data

Signed-off-by: aoiasd <[email protected]>
milvus-io · Jan 16, 2025 · 6421d19 · 6421d19
1 parent dc1acb3
commit 6421d19
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 8 deletions.
diff --git a/internal/querynodev2/segments/segment.go b/internal/querynodev2/segments/segment.go
@@ -62,6 +62,7 @@ import (
 	"github.com/milvus-io/milvus/pkg/util/indexparams"
 	"github.com/milvus-io/milvus/pkg/util/merr"
 	"github.com/milvus-io/milvus/pkg/util/metautil"
+	"github.com/milvus-io/milvus/pkg/util/metric"
 	"github.com/milvus-io/milvus/pkg/util/paramtable"
 	"github.com/milvus-io/milvus/pkg/util/timerecord"
 	"github.com/milvus-io/milvus/pkg/util/typeutil"
@@ -1057,8 +1058,18 @@ func (s *LocalSegment) innerLoadIndex(ctx context.Context,
 			// Skip warnup chunk cache when
 			// . scalar data
 			// . index has row data
-			// . vector was function output
-			if !typeutil.IsVectorType(fieldType) || s.HasRawData(indexInfo.GetFieldID()) || fieldSchema.IsFunctionOutput {
+			// . vector was bm25 function output
+
+			if !typeutil.IsVectorType(fieldType) || s.HasRawData(indexInfo.GetFieldID()) {
+				return nil
+			}
+
+			metricType, err := funcutil.GetAttrByKeyFromRepeatedKV(common.MetricTypeKey, indexInfo.IndexParams)
+			if err != nil {
+				return fmt.Errorf("metric type not exist in index params")
+			}
+
+			if metricType == metric.BM25 {
 				return nil
 			}
 

diff --git a/internal/querynodev2/segments/segment_loader.go b/internal/querynodev2/segments/segment_loader.go
@@ -57,6 +57,7 @@ import (
 	"github.com/milvus-io/milvus/pkg/util/funcutil"
 	"github.com/milvus-io/milvus/pkg/util/hardware"
 	"github.com/milvus-io/milvus/pkg/util/merr"
+	"github.com/milvus-io/milvus/pkg/util/metric"
 	"github.com/milvus-io/milvus/pkg/util/paramtable"
 	"github.com/milvus-io/milvus/pkg/util/syncutil"
 	"github.com/milvus-io/milvus/pkg/util/timerecord"
@@ -1509,12 +1510,22 @@ func getResourceUsageEstimateOfSegment(schema *schemapb.CollectionSchema, loadIn
 			if !estimateResult.HasRawData && !isVectorType {
 				shouldCalculateDataSize = true
 			}
-			if !estimateResult.HasRawData && isVectorType && !fieldSchema.IsFunctionOutput {
-				mmapChunkCache := paramtable.Get().QueryNodeCfg.MmapChunkCache.GetAsBool()
-				if mmapChunkCache {
-					segmentDiskSize += binlogSize
-				} else {
-					segmentMemorySize += binlogSize
+
+			if !estimateResult.HasRawData && isVectorType {
+				metricType, err := funcutil.GetAttrByKeyFromRepeatedKV(common.MetricTypeKey, fieldIndexInfo.IndexParams)
+				if err != nil {
+					return nil, errors.Wrapf(err, "failed to estimate resource usage of index, metric type nout found, collection %d, segment %d, indexBuildID %d",
+						loadInfo.GetCollectionID(),
+						loadInfo.GetSegmentID(),
+						fieldIndexInfo.GetBuildID())
+				}
+				if metricType != metric.BM25 {
+					mmapChunkCache := paramtable.Get().QueryNodeCfg.MmapChunkCache.GetAsBool()
+					if mmapChunkCache {
+						segmentDiskSize += binlogSize
+					} else {
+						segmentMemorySize += binlogSize
+					}
 				}
 			}
 		} else {