Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Skip creating partition rate limiters when not enable #38816

Merged
merged 8 commits into from
Jan 23, 2025
Merged

enhance: Skip creating partition rate limiters when not enable #38816

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f9b170
enhance: Skip creating partition rate limiters when not enable
bigsheeper Nov 26, 2024
ca06372
Merge branch 'master' of https://github.com/milvus-io/milvus into 241…
bigsheeper Dec 30, 2024
5420a3e
fix
bigsheeper Dec 30, 2024
a1c52ed
Merge branch 'master' of https://github.com/milvus-io/milvus into 241…
bigsheeper Dec 30, 2024
4d3958f
Merge branch 'master' of https://github.com/milvus-io/milvus into 241…
bigsheeper Dec 31, 2024
33e7c32
Merge branch 'master' of https://github.com/milvus-io/milvus into 241…
bigsheeper Jan 9, 2025
5df354c
Merge branch 'master' of https://github.com/milvus-io/milvus into 241…
bigsheeper Jan 14, 2025
4cbf46c
remove redundant call
bigsheeper Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions internal/rootcoord/quota_center.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,15 @@ func (q *QuotaCenter) calculateRates() error {
func (q *QuotaCenter) resetAllCurrentRates() error {
clusterLimiter := newParamLimiterFunc(internalpb.RateScope_Cluster, allOps)()
q.rateLimiter = rlinternal.NewRateLimiterTree(clusterLimiter)

enablePartitionRateLimit := false
for rt := range getRateTypes(internalpb.RateScope_Partition, allOps) {
r := quota.GetQuotaValue(internalpb.RateScope_Partition, rt, Params)
if Limit(r) != Inf {
enablePartitionRateLimit = true
}
}
bigsheeper marked this conversation as resolved.
Show resolved Hide resolved

initLimiters := func(sourceCollections map[int64]map[int64][]int64) {
for dbID, collections := range sourceCollections {
for collectionID, partitionIDs := range collections {
Expand All @@ -1192,18 +1201,19 @@ func (q *QuotaCenter) resetAllCurrentRates() error {
}
return limitVal
}
q.rateLimiter.GetOrCreateCollectionLimiters(dbID, collectionID,
newParamLimiterFunc(internalpb.RateScope_Database, allOps),
newParamLimiterFuncWithLimitFunc(internalpb.RateScope_Collection, allOps, getCollectionLimitVal))

if !enablePartitionRateLimit {
continue
}
for _, partitionID := range partitionIDs {
q.rateLimiter.GetOrCreatePartitionLimiters(dbID, collectionID, partitionID,
newParamLimiterFunc(internalpb.RateScope_Database, allOps),
newParamLimiterFuncWithLimitFunc(internalpb.RateScope_Collection, allOps, getCollectionLimitVal),
newParamLimiterFunc(internalpb.RateScope_Partition, allOps))
}
if len(partitionIDs) == 0 {
q.rateLimiter.GetOrCreateCollectionLimiters(dbID, collectionID,
newParamLimiterFunc(internalpb.RateScope_Database, allOps),
newParamLimiterFuncWithLimitFunc(internalpb.RateScope_Collection, allOps, getCollectionLimitVal))
}
}
if len(collections) == 0 {
q.rateLimiter.GetOrCreateDatabaseLimiters(dbID, newParamLimiterFunc(internalpb.RateScope_Database, allOps))
Expand Down
Loading